Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving SurfaceHandler to react.interfaces.fabric #38759

Closed
wants to merge 2 commits into from
Closed

Moving SurfaceHandler to react.interfaces.fabric #38759

wants to merge 2 commits into from

Commits on Aug 3, 2023

  1. Revert D47915065 

    Summary:
See the discussion in D47915065.

In order to expose `getSurfaceHandler()` from an interface ReactSurface in D47109982, we need this to be public.

All methods in an interface are public and the implementing class can not have a restricted visibility than the interface.

Differential Revision: D48003816

fbshipit-source-id: ebefeb35f7d3289a442f3885feff76387b78a57e
    @arushikesarwani94 @facebook-github-bot
    arushikesarwani94 authored and facebook-github-bot committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    588b3f3 View commit details
    Browse the repository at this point in the history

  2. Moving SurfaceHandler to react.interfaces.fabric (facebook#38759) 

    Summary:
Pull Request resolved: facebook#38759

As part of refactoring the `ReactSurface`, moving the `SurfaceHandler` interface to `react.interfaces.fabric`.

changelog: [internal] internal

Reviewed By: christophpurrer

Differential Revision: D48006184

fbshipit-source-id: 6c0a6eb122a89be1950f593da55cfe4dcd84698f
    @arushikesarwani94 @facebook-github-bot
    arushikesarwani94 authored and facebook-github-bot committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    4c2b4f5 View commit details
    Browse the repository at this point in the history