Add @react-native/typescript-config #37345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45721088 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 10, 2023
Summary: Pull Request resolved: facebook#37345 This moves from `tsconfig/react-native`, a centralized repository of tsconfigs, to `react-native/typescript-config`, a package maintained as part of the RN monorepo. We end up wanting to make changes where the versions are coupled, so this publishes them as part of the same repo, etc. It also means Meta engineers can more freely make changes to it with normal approval processes. Differential Revision: D45721088 fbshipit-source-id: 033a229a3c22133542d1e3afa8afa10b98328674
NickGerleman
force-pushed
the
export-D45721088
branch
from
f8029c3
to
b45b807
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45721088 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 10, 2023
Summary: Pull Request resolved: facebook#37345 This moves from `tsconfig/react-native`, a centralized repository of tsconfigs, to `react-native/typescript-config`, a package maintained as part of the RN monorepo. We end up wanting to make changes where the versions are coupled, so this publishes them as part of the same repo, etc. It also means Meta engineers can more freely make changes to it with normal approval processes. Differential Revision: D45721088 fbshipit-source-id: de995bdaddd14218119b27076e19b63f7694c08e
NickGerleman
force-pushed
the
export-D45721088
branch
from
b45b807
to
62a8c0d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45721088 |
Base commit: 61fc1a5 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 10, 2023
Summary: Pull Request resolved: facebook#37345 This moves from `tsconfig/react-native`, a centralized repository of tsconfigs, to `react-native/typescript-config`, a package maintained as part of the RN monorepo. We end up wanting to make changes where the versions are coupled, so this publishes them as part of the same repo, etc. It also means Meta engineers can more freely make changes to it with normal approval processes. Differential Revision: D45721088 fbshipit-source-id: 7f1620b0b5604e7cff8ce26ed4b6744559bcdb63
NickGerleman
force-pushed
the
export-D45721088
branch
from
62a8c0d
to
703792f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45721088 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45721088 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 10, 2023
Summary: Pull Request resolved: facebook#37345 This moves from `tsconfig/react-native`, a centralized repository of tsconfigs, to `react-native/typescript-config`, a package maintained as part of the RN monorepo. We end up wanting to make changes where the versions are coupled, so this publishes them as part of the same repo, etc. It also means Meta engineers can more freely make changes to it with normal approval processes. Changelog: [General][Added] - Add react-native/typescript-config Reviewed By: cortinico Differential Revision: D45721088 fbshipit-source-id: 3aa4f570fd2763cf8c2d37e9e7aaaf63fa1ad373
NickGerleman
force-pushed
the
export-D45721088
branch
from
703792f
to
b42c5d8
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 10, 2023
Summary: Pull Request resolved: facebook#37345 This moves from `tsconfig/react-native`, a centralized repository of tsconfigs, to `react-native/typescript-config`, a package maintained as part of the RN monorepo. We end up wanting to make changes where the versions are coupled, so this publishes them as part of the same repo, etc. It also means Meta engineers can more freely make changes to it with normal approval processes. Changelog: [General][Added] - Add react-native/typescript-config Reviewed By: cortinico Differential Revision: D45721088 fbshipit-source-id: e0c40782cf8b733c974c160f70194c14ce7e6b96
NickGerleman
force-pushed
the
export-D45721088
branch
from
b42c5d8
to
315a24f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45721088 |
Summary: Pull Request resolved: facebook#37345 This moves from `tsconfig/react-native`, a centralized repository of tsconfigs, to `react-native/typescript-config`, a package maintained as part of the RN monorepo. We end up wanting to make changes where the versions are coupled, so this publishes them as part of the same repo, etc. It also means Meta engineers can more freely make changes to it with normal approval processes. Changelog: [General][Added] - Add react-native/typescript-config Reviewed By: cortinico Differential Revision: D45721088 fbshipit-source-id: 47bcefb95bbde8f35f173cd5ebeb131e57f5112e
NickGerleman
force-pushed
the
export-D45721088
branch
from
315a24f
to
30ba0b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45721088 |
|
This pull request has been merged in cae52f6. |
blakef
pushed a commit
to blakef/template
that referenced
this pull request
Feb 28, 2024
Summary: Pull Request resolved: facebook/react-native#37345 This moves from `tsconfig/react-native`, a centralized repository of tsconfigs, to `react-native/typescript-config`, a package maintained as part of the RN monorepo. We end up wanting to make changes where the versions are coupled, so this publishes them as part of the same repo, etc. It also means Meta engineers can more freely make changes to it with normal approval processes. Changelog: [General][Added] - Add react-native/typescript-config Reviewed By: cortinico Differential Revision: D45721088 fbshipit-source-id: b949bffb14014695abf3b9b359d3f5e30bfc8919 Original: facebook/react-native@cae52f6
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#37345 This moves from `tsconfig/react-native`, a centralized repository of tsconfigs, to `react-native/typescript-config`, a package maintained as part of the RN monorepo. We end up wanting to make changes where the versions are coupled, so this publishes them as part of the same repo, etc. It also means Meta engineers can more freely make changes to it with normal approval processes. Changelog: [General][Added] - Add react-native/typescript-config Reviewed By: cortinico Differential Revision: D45721088 fbshipit-source-id: b949bffb14014695abf3b9b359d3f5e30bfc8919 Original-Commit: facebook/react-native@cae52f6
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#37345 This moves from `tsconfig/react-native`, a centralized repository of tsconfigs, to `react-native/typescript-config`, a package maintained as part of the RN monorepo. We end up wanting to make changes where the versions are coupled, so this publishes them as part of the same repo, etc. It also means Meta engineers can more freely make changes to it with normal approval processes. Changelog: [General][Added] - Add react-native/typescript-config Reviewed By: cortinico Differential Revision: D45721088 fbshipit-source-id: b949bffb14014695abf3b9b359d3f5e30bfc8919 Original-Commit: facebook/react-native@cae52f6
liamjones
reviewed
May 14, 2024
| "allowSyntheticDefaultImports": true, | ||
| "esModuleInterop": true, | ||
| "skipLibCheck": true, | ||
| // Causes issues with package.json "exports" |
There was a problem hiding this comment.
@NickGerleman apologies for the ping - do you know what the specifics of the issue mentioned here are?
It looks like you originally changed it in the old repo but the commit message doesn't explain why: tsconfig/bases@5b4e858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This moves from
tsconfig/react-native, a centralized repository of tsconfigs, toreact-native/typescript-config, a package maintained as part of the RN monorepo.We end up wanting to make changes where the versions are coupled, so this publishes them as part of the same repo, etc. It also means Meta engineers can more freely make changes to it with normal approval processes.
I also used this opportunity to fix the file-structure of
eslint-config-react-native-communtiy, andeslint-plugin-react-native-communtiyto match the name they were renamed to as part of 0.72.Differential Revision: D45721088