Update paths in a new setup to fix nightlies #36535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44214309 |
Base commit: 0c5c07f |
|
This pull request was exported from Phabricator. Differential Revision: D44214309 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Mar 20, 2023
Summary: Pull Request resolved: facebook#36535 Changelog: [Internal] - We should be copying `/packages/react-native/package.json`, not root `package.json` - Updating CircleCI config's target directory where hermes artifacts should be copied Reviewed By: cortinico Differential Revision: D44214309 fbshipit-source-id: e26bb38a6c520eeb9610bdb325920f686c6b5087
Summary: Changelog: [Internal] In order to make `react-native/tester` imports work, adding this package to `xplat/js/public` Also moving devDependecies from `react-native/tester/package.json` to root package json to avoid checking in dev dependencies in `xplat/js/public/node_modules` Differential Revision: https://internalfb.com/D44030539 fbshipit-source-id: 04f5b627977a1c0ca2e5b91d631c12a90dee6d79
Summary: Changelog: [Internal] Its better to have one source of truth, so we won't loose any changes if one of the files will be updated Reviewed By: cortinico Differential Revision: D44138311 fbshipit-source-id: 20e78f06c8417ac88129bd864acf1ce553d409ef
…or react-native package Summary: Changelog: [Internal] - Added option to include react-native package in forEachPackage func - Used this in align-package-versions.js Reviewed By: cortinico Differential Revision: D44152939 fbshipit-source-id: 480309f4bda32ed9776011e0cef34bbb93e50cd1
Summary: Changelog: [Internal] added missing `InheritParentConfig: true` to .clang-tidy configs across `ReactAndroid` and `ReactCommon` was initially flagged by linters in D43977381 Reviewed By: javache Differential Revision: D44199124 fbshipit-source-id: c3c0ffa376e2045b11cd8e9920fea9167fef2900
Summary: Pull Request resolved: facebook#36535 Changelog: [Internal] - We should be copying `/packages/react-native/package.json`, not root `package.json` - Updating CircleCI config's target directory where hermes artifacts should be copied Reviewed By: cortinico Differential Revision: D44214309 fbshipit-source-id: bc5102a7d02c06aef28852461c363e8746e30815
|
This pull request was exported from Phabricator. Differential Revision: D44214309 |
|
This pull request has been merged in 4b6b706. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36535 Changelog: [Internal] - We should be copying `/packages/react-native/package.json`, not root `package.json` - Updating CircleCI config's target directory where hermes artifacts should be copied Reviewed By: cortinico Differential Revision: D44214309 fbshipit-source-id: af84897df3931c6a2d6a902b33c71b665c3fcefc
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36535 Changelog: [Internal] - We should be copying `/packages/react-native/package.json`, not root `package.json` - Updating CircleCI config's target directory where hermes artifacts should be copied Reviewed By: cortinico Differential Revision: D44214309 fbshipit-source-id: af84897df3931c6a2d6a902b33c71b665c3fcefc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
/packages/react-native/package.json, not rootpackage.jsonDifferential Revision: D44214309