Skip to content

Commit

Permalink
Update paths in a new setup to fix nightlies (#36535)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #36535

Changelog: [Internal]

- We should be copying `/packages/react-native/package.json`, not root `package.json`
- Updating CircleCI config's target directory where hermes artifacts should be copied

Reviewed By: cortinico

Differential Revision: D44214309

fbshipit-source-id: af84897df3931c6a2d6a902b33c71b665c3fcefc
  • Loading branch information
hoxyq authored and facebook-github-bot committed Mar 20, 2023
1 parent c9db994 commit 4b6b706
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1510,9 +1510,9 @@ jobs:
cp -r $HERMES_WS_DIR/win64-bin/* ./packages/react-native/sdks/hermesc/win64-bin/.
cp -r $HERMES_WS_DIR/linux64-bin/* ./packages/react-native/sdks/hermesc/linux64-bin/.
mkdir -p ./ReactAndroid/external-artifacts/artifacts/
cp $HERMES_WS_DIR/hermes-runtime-darwin/hermes-ios-debug.tar.gz ./ReactAndroid/external-artifacts/artifacts/hermes-ios-debug.tar.gz
cp $HERMES_WS_DIR/hermes-runtime-darwin/hermes-ios-release.tar.gz ./ReactAndroid/external-artifacts/artifacts/hermes-ios-release.tar.gz
mkdir -p ./packages/react-native/ReactAndroid/external-artifacts/artifacts/
cp $HERMES_WS_DIR/hermes-runtime-darwin/hermes-ios-debug.tar.gz ./packages/react-native/ReactAndroid/external-artifacts/artifacts/hermes-ios-debug.tar.gz
cp $HERMES_WS_DIR/hermes-runtime-darwin/hermes-ios-release.tar.gz ./packages/react-native/ReactAndroid/external-artifacts/artifacts/hermes-ios-release.tar.gz
- run_yarn
- download_gradle_dependencies
Expand Down
5 changes: 4 additions & 1 deletion scripts/set-rn-version.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ const tmpVersioningFolder = fs.mkdtempSync(
echo(`The temp versioning folder is ${tmpVersioningFolder}`);

saveFiles(
['package.json', 'packages/react-native/template/package.json'],
[
'packages/react-native/package.json',
'packages/react-native/template/package.json',
],
tmpVersioningFolder,
);

Expand Down

0 comments on commit 4b6b706

Please sign in to comment.