Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update paths in a new setup to fix nightlies #36535

Closed
wants to merge 5 commits into from
Closed

Update paths in a new setup to fix nightlies #36535

wants to merge 5 commits into from

Commits on Mar 20, 2023

  1. RN: add @react-native/tester as a workspace to xplat/js/public 

    Summary:
Changelog: [Internal]

In order to make `react-native/tester` imports work, adding this package to `xplat/js/public`

Also moving devDependecies from `react-native/tester/package.json` to root package json to avoid checking in dev dependencies in `xplat/js/public/node_modules`

Differential Revision: https://internalfb.com/D44030539

fbshipit-source-id: 04f5b627977a1c0ca2e5b91d631c12a90dee6d79
    @facebook-github-bot
    hoxy authored and facebook-github-bot committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    44cf352 View commit details
    Browse the repository at this point in the history

  2. refactor: move README.md in prepack, instead of having two copies 

    Summary:
Changelog: [Internal]

Its better to have one source of truth, so we won't loose any changes if one of the files will be updated

Reviewed By: cortinico

Differential Revision: D44138311

fbshipit-source-id: 20e78f06c8417ac88129bd864acf1ce553d409ef
    @facebook-github-bot
    hoxy authored and facebook-github-bot committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    23a5a26 View commit details
    Browse the repository at this point in the history

  3. fix[align-package-version]: fixed updating application dependencies f… 

    …or react-native package

Summary:
Changelog: [Internal]

- Added option to include react-native package in forEachPackage func
- Used this in align-package-versions.js

Reviewed By: cortinico

Differential Revision: D44152939

fbshipit-source-id: 480309f4bda32ed9776011e0cef34bbb93e50cd1
    @facebook-github-bot
    hoxy authored and facebook-github-bot committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    84e69fd View commit details
    Browse the repository at this point in the history

  4. fix: added missing InheritParentConfig: true to .clang-tidy configs 

    Summary:
Changelog: [Internal]

added missing `InheritParentConfig: true` to .clang-tidy configs across `ReactAndroid` and `ReactCommon`

was initially flagged by linters in D43977381

Reviewed By: javache

Differential Revision: D44199124

fbshipit-source-id: c3c0ffa376e2045b11cd8e9920fea9167fef2900
    @facebook-github-bot
    hoxy authored and facebook-github-bot committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    45fdf31 View commit details
    Browse the repository at this point in the history

  5. Update paths in a new setup to fix nightlies (facebook#36535) 

    Summary:
Pull Request resolved: facebook#36535

Changelog: [Internal]

- We should be copying `/packages/react-native/package.json`, not root `package.json`
- Updating CircleCI config's target directory where hermes artifacts should be copied

Reviewed By: cortinico

Differential Revision: D44214309

fbshipit-source-id: bc5102a7d02c06aef28852461c363e8746e30815
    @hoxyq @facebook-github-bot
    hoxyq authored and facebook-github-bot committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    31d2487 View commit details
    Browse the repository at this point in the history