Breaking - Bump minimum Node version from 14 to 16 #36217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43436883 |
Differential Revision: D43421085 fbshipit-source-id: c8a0419db7cf22156cdeeb9d89040cb6c5bb2a0f
Summary: ## Bump minimum Node JS version to 16 via `react-native/package.json#engines` In facebook#35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut. Node 14 [ends maintenance releases in April](https://github.com/nodejs/release#release-schedule), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. ## Insert `engines` into `template/package.json` The constraint at `react-native/package.json#engines` ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) `yarn start`. Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum. Insertion of `engines` below existing `package.json` fields is consistent with [`sort-package-json`](https://github.com/keithamus/sort-package-json/blob/main/defaultRules.md) and [`prettier-package-json`](https://github.com/cameronhunter/prettier-package-json/blob/main/src/defaultOptions.ts) - and keeps it out of the way of fields RN developers are likely to be more concerned about. ## Docs PR facebook/react-native-website#3580 ## Changelog: [General][Breaking] Bump minimum Node JS version to 16 Differential Revision: D43436883 fbshipit-source-id: 3ccef744b15e295a31717bd94b61b0019c51b3e3
|
This pull request was exported from Phabricator. Differential Revision: D43436883 |
robhogan
force-pushed
the
export-D43436883
branch
from
582849c
to
f40d4ae
Compare
cortinico
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
LGTM 👍 We also need to update this:
https://github.com/react-native-community/cli/blob/e7d596a13e3122be6b31c52e1356bd72d10b8379/packages/cli-doctor/src/tools/versionRanges.ts#L3
|
This pull request has been merged in afc91de. |
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Feb 23, 2023
Summary: Following the same change in React Native for the upcoming 0.72 release ([facebook/react-native#36217](facebook/react-native#36217)), increase minimum supported Node.js version for all Metro packages to `>=16`. Changelog: **[Breaking]** Increase minimum Node version from 14 to 16 Reviewed By: hoxyq Differential Revision: D43464209 fbshipit-source-id: f0f573211838cbe5f79bc16fa005b86c180b41c4
arushikesarwani94
added a commit
to facebook/react-native-website
that referenced
this pull request
Mar 3, 2023
React Native is increasing the minimum Node JS requirement from 14 to 16 in facebook/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
arushikesarwani94
added a commit
to facebook/react-native-website
that referenced
this pull request
Mar 3, 2023
React Native is increasing the minimum Node JS requirement from 14 to 16 in facebook/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 26, 2023
Summary: **NOTE**: This is a **BREAKING** change. TLDR; Enforce minimum Node.js v16 in all RN packages. This diff **Updates Node.js to v16** across all RN packages. #### Context: - For RN development and new project created; bump to node 16 was in #36217 - Recently `react-native-windows` also; updated node to v16, microsoft/react-native-windows#11500 #### Changes: - [BREAKING] Update Node.js to v16 across all RN packages under 'packages/' dir ## Changelog: [GENERAL][BREAKING] - Update Node.js to v16 in all RN packages Pull Request resolved: #37073 Test Plan: - `yarn lint && yarn flow && yarn test-ci` --> _should be green_ Reviewed By: cipolleschi Differential Revision: D45306108 Pulled By: jacdebug fbshipit-source-id: e3ba7d0151b86a6a0a3d63fb29c2bd887e1ac1e7
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: **NOTE**: This is a **BREAKING** change. TLDR; Enforce minimum Node.js v16 in all RN packages. This diff **Updates Node.js to v16** across all RN packages. #### Context: - For RN development and new project created; bump to node 16 was in facebook#36217 - Recently `react-native-windows` also; updated node to v16, microsoft/react-native-windows#11500 #### Changes: - [BREAKING] Update Node.js to v16 across all RN packages under 'packages/' dir ## Changelog: [GENERAL][BREAKING] - Update Node.js to v16 in all RN packages Pull Request resolved: facebook#37073 Test Plan: - `yarn lint && yarn flow && yarn test-ci` --> _should be green_ Reviewed By: cipolleschi Differential Revision: D45306108 Pulled By: jacdebug fbshipit-source-id: e3ba7d0151b86a6a0a3d63fb29c2bd887e1ac1e7
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36217 ## Bump minimum Node JS version to 16 via `react-native/package.json#engines` In facebook#35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut. Node 14 [ends maintenance releases in April](https://github.com/nodejs/release#release-schedule), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. ## Insert `engines` into `template/package.json` The constraint at `react-native/package.json#engines` ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) `yarn start`. Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum. Insertion of `engines` below existing `package.json` fields is consistent with [`sort-package-json`](https://github.com/keithamus/sort-package-json/blob/main/defaultRules.md) and [`prettier-package-json`](https://github.com/cameronhunter/prettier-package-json/blob/main/src/defaultOptions.ts) - and keeps it out of the way of fields RN developers are likely to be more concerned about. ## Docs PR facebook/react-native-website#3580 ## Changelog: [General][Breaking] Bump minimum Node JS version to 16 Reviewed By: jacdebug Differential Revision: D43436883 fbshipit-source-id: 0b369487fe44fe777e6fedc2299973a5fddd06b2
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: **NOTE**: This is a **BREAKING** change. TLDR; Enforce minimum Node.js v16 in all RN packages. This diff **Updates Node.js to v16** across all RN packages. #### Context: - For RN development and new project created; bump to node 16 was in facebook#36217 - Recently `react-native-windows` also; updated node to v16, microsoft/react-native-windows#11500 #### Changes: - [BREAKING] Update Node.js to v16 across all RN packages under 'packages/' dir ## Changelog: [GENERAL][BREAKING] - Update Node.js to v16 in all RN packages Pull Request resolved: facebook#37073 Test Plan: - `yarn lint && yarn flow && yarn test-ci` --> _should be green_ Reviewed By: cipolleschi Differential Revision: D45306108 Pulled By: jacdebug fbshipit-source-id: e3ba7d0151b86a6a0a3d63fb29c2bd887e1ac1e7
arushikesarwani94
added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
Summary: Following the same change in React Native (facebook/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18. Changelog: [Breaking] Increase minimum Node version from 16 to 18 Differential Revision: D46584012 fbshipit-source-id: d73bed37909def72a8d954ffa3d8852605d7267b
arushikesarwani94
added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
Summary: Pull Request resolved: facebook#1004 Following the same change in React Native (facebook/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18. Changelog: [Breaking] Increase minimum Node version from 16 to 18 Reviewed By: NickGerleman Differential Revision: D46584012 fbshipit-source-id: 11b328db5a61bf509defae514f34e0eb39e231d9
arushikesarwani94
added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 9, 2023
Summary: Pull Request resolved: facebook#1004 Following the same change in React Native (facebook/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18. Changelog: [Breaking] Increase minimum Node version from 16 to 18 Reviewed By: NickGerleman Differential Revision: D46584012 fbshipit-source-id: 7592205d6aed885ffb3745b756f3fb577fd4eb98
arushikesarwani94
added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 13, 2023
Summary: Pull Request resolved: facebook#1004 Following the same change in React Native (facebook/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18. Changelog: [Breaking] Increase minimum Node version from 16 to 18 Reviewed By: NickGerleman Differential Revision: D46584012 fbshipit-source-id: f1409ec12d1ab11e2e71b09595a77daafea19cea
arushikesarwani94
added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 15, 2023
Summary: Pull Request resolved: facebook#1004 Following the same change in React Native (facebook/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18. Changelog: [Breaking] Increase minimum Node version from 16 to 18 Reviewed By: NickGerleman Differential Revision: D46584012 fbshipit-source-id: 27e78fb40cf16e3222201b94aeb5649f135ffdbd
arushikesarwani94
added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 15, 2023
Summary: Pull Request resolved: facebook#1004 Following the same change in React Native (facebook/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18. Changelog: [Breaking] Increase minimum Node version from 16 to 18 Reviewed By: NickGerleman Differential Revision: D46584012 fbshipit-source-id: 23cfe044085d0bf4d79d26a41bff779cf92d3f24
arushikesarwani94
added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
Summary: Pull Request resolved: facebook#1004 Following the same change in React Native (facebook/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18. Changelog: [Breaking] Increase minimum Node version from 16 to 18 Reviewed By: NickGerleman Differential Revision: D46584012 fbshipit-source-id: a9f2b193cae0a63cace2e6c45407d36b9550df23
arushikesarwani94
added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
Summary: Pull Request resolved: facebook#1004 Following the same change in React Native (facebook/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18. Changelog: [Breaking] Increase minimum Node version from 16 to 18 Reviewed By: NickGerleman Differential Revision: D46584012 fbshipit-source-id: d5eb1d4de8456158e503686003f3f25475386d54
arushikesarwani94
added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
Summary: Pull Request resolved: facebook#1004 Following the same change in React Native (facebook/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18. Changelog: [Breaking] Increase minimum Node version from 16 to 18 Reviewed By: NickGerleman Differential Revision: D46584012 fbshipit-source-id: 1c881a1e220c80edcb93ea43605fab6737c13d80
arushikesarwani94
added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
Summary: Pull Request resolved: facebook#1004 Following the same change in React Native (facebook/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18. Changelog: [Breaking] Increase minimum Node version from 16 to 18 Reviewed By: NickGerleman Differential Revision: D46584012 fbshipit-source-id: 81f86dba5081e349007e30abbc904f3422c3c12e
arushikesarwani94
added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 20, 2023
Summary: Pull Request resolved: facebook#1004 Following the same change in React Native (facebook/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18. Changelog: [Breaking] Increase minimum Node version from 16 to 18 Reviewed By: NickGerleman Differential Revision: D46584012 fbshipit-source-id: fd973f573b4025d30f586d5bc74bf5053875ad59
arushikesarwani94
added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 21, 2023
Summary: Pull Request resolved: facebook#1004 Following the same change in React Native (facebook/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18. Changelog: [Breaking] Increase minimum Node version from 16 to 18 Reviewed By: NickGerleman Differential Revision: D46584012 fbshipit-source-id: 144bdad877bce19cb9f986c910b91d3ff7a2282b
arushikesarwani94
added a commit
to arushikesarwani94/metro
that referenced
this pull request
Jun 21, 2023
Summary: Pull Request resolved: facebook#1004 Following the same change in React Native (facebook/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18. Changelog: [Breaking] Increase minimum Node version from 16 to 18 Reviewed By: NickGerleman Differential Revision: D46584012 fbshipit-source-id: fdd05a0be93c745c22fe2f8cc0dcfe2fec7cb625
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Jun 22, 2023
Summary: Pull Request resolved: #1004 Following the same change in React Native (facebook/react-native#36217), increase minimum supported Node.js version for all Metro packages to >=18. Changelog: [Breaking] Increase minimum Node version from 16 to 18 Reviewed By: NickGerleman Differential Revision: D46584012 fbshipit-source-id: fde63f748667eb30e00577f6fe0dc472fa06121a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Bump minimum Node JS version to 16 via
react-native/package.json#enginesIn #35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut.
Insert
enginesintotemplate/package.jsonThe constraint at
react-native/package.json#enginesensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.)yarn start.Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum.
Insertion of
enginesbelow existingpackage.jsonfields is consistent withsort-package-jsonandprettier-package-json- and keeps it out of the way of fields RN developers are likely to be more concerned about.Changelog:
[General][Breaking] Bump minimum Node JS version to 16
Differential Revision: D43436883