-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: RN's minimum Node version 14->16 #3580
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
robhogan
added a commit
to robhogan/react-native
that referenced
this pull request
Feb 20, 2023
Summary: ## Bump minimum Node JS version to 16 via `react-native/package.json#engines` In facebook#35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut. Node 14 [ends maintenance releases in April](https://github.com/nodejs/release#release-schedule), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. ## Insert `engines` into `template/package.json` The constraint at `react-native/package.json#engines` ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) `yarn start`. Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum. Insertion of `engines` below existing `package.json` fields is consistent with [`sort-package-json`](https://github.com/keithamus/sort-package-json/blob/main/defaultRules.md) and [`prettier-package-json`](https://github.com/cameronhunter/prettier-package-json/blob/main/src/defaultOptions.ts) - and keeps it out of the way of fields RN developers are likely to be more concerned about. ## Docs PR facebook/react-native-website#3580 ## Changelog: [General][Breaking] Bump minimum Node JS version to 16 Differential Revision: D43436883 fbshipit-source-id: 3ccef744b15e295a31717bd94b61b0019c51b3e3
cortinico
approved these changes
Feb 20, 2023
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Feb 20, 2023
Summary: Pull Request resolved: #36217 ## Bump minimum Node JS version to 16 via `react-native/package.json#engines` In #35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut. Node 14 [ends maintenance releases in April](https://github.com/nodejs/release#release-schedule), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. ## Insert `engines` into `template/package.json` The constraint at `react-native/package.json#engines` ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) `yarn start`. Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum. Insertion of `engines` below existing `package.json` fields is consistent with [`sort-package-json`](https://github.com/keithamus/sort-package-json/blob/main/defaultRules.md) and [`prettier-package-json`](https://github.com/cameronhunter/prettier-package-json/blob/main/src/defaultOptions.ts) - and keeps it out of the way of fields RN developers are likely to be more concerned about. ## Docs PR facebook/react-native-website#3580 ## Changelog: [General][Breaking] Bump minimum Node JS version to 16 Reviewed By: jacdebug Differential Revision: D43436883 fbshipit-source-id: 0b369487fe44fe777e6fedc2299973a5fddd06b2
robhogan
changed the title
Node version minumum 14->16
Docs: RN's minimum Node version 14->16
Feb 20, 2023
arushikesarwani94
added a commit
that referenced
this pull request
Mar 3, 2023
React Native is increasing the minimum Node JS requirement from 14 to 16 in facebook/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
arushikesarwani94
added a commit
that referenced
this pull request
Mar 3, 2023
React Native is increasing the minimum Node JS requirement from 14 to 16 in facebook/react-native#36217, #3580 for 0.72 onwards. Updating our Windows documentation to reflect the same.
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36217 ## Bump minimum Node JS version to 16 via `react-native/package.json#engines` In facebook#35443 we stopped running CI in Node 14 - this follows up by formally making Node 16 the minimum supported version ahead of the 0.72 cut. Node 14 [ends maintenance releases in April](https://github.com/nodejs/release#release-schedule), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. ## Insert `engines` into `template/package.json` The constraint at `react-native/package.json#engines` ensures the minimum at install/init time, with package managers providing an actionable error or warning if the constraint is not met. However, it doesn't help guide users to a supported version if on an existing project they run (e.g.) `yarn start`. Adding a constraint to the template helps prevent accidental use of an older version, as well as providing a clear reference for the current minimum. Insertion of `engines` below existing `package.json` fields is consistent with [`sort-package-json`](https://github.com/keithamus/sort-package-json/blob/main/defaultRules.md) and [`prettier-package-json`](https://github.com/cameronhunter/prettier-package-json/blob/main/src/defaultOptions.ts) - and keeps it out of the way of fields RN developers are likely to be more concerned about. ## Docs PR facebook/react-native-website#3580 ## Changelog: [General][Breaking] Bump minimum Node JS version to 16 Reviewed By: jacdebug Differential Revision: D43436883 fbshipit-source-id: 0b369487fe44fe777e6fedc2299973a5fddd06b2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the minimum Node version increasing from 14 to 16 from the next release, as per facebook/react-native#36217