Bump node version from 16 to 18 #35443

leotm · 2022-11-23T15:13:37Z

Summary

Node 18: https://nodejs.org/en/blog/announcements/v18-release-announce/

Node 16 EOL: 2023-09-11
https://nodejs.org/en/blog/announcements/nodejs16-eol/

Node 18 EOL: 2025-04-30

Follow-up

Ref

Bump node version react-native-community/docker-android#187

cc @ramonmedel @cortinico @gengjiawen @kelset 🙌

Changelog

[JavaScript] [Changed] - Bump node version from 16 to 18

Test Plan

Everything builds and runs as expected

Follow-up

Update docs
https://reactnative.dev/contributing/changelogs-in-pull-requests

To reflect

react-native/packages/react-native-bots/dangerfile.js

Line 62 in 55b09da

    
           /\[\s?(ANDROID|GENERAL|IOS|JS|JAVASCRIPT|INTERNAL)\s?\]\s?\[\s?(ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY)\s?\]\s*?-?\s*?(.*)/gi;

@ramonmedel

Node 18: https://nodejs.org/de/blog/announcements/v18-release-announce/ Node 16 EOL: 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ Node 18 EOL: 2025-04-30 Ref - react-native-community/docker-android#187 cc @ramonmedel @cortinico @gengjiawen

analysis-bot · 2022-11-23T15:39:22Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,102,569	+0
android	hermes	armeabi-v7a	6,470,637	+0
android	hermes	x86	7,520,037	+0
android	hermes	x86_64	7,378,724	+0
android	jsc	arm64-v8a	8,967,444	+0
android	jsc	armeabi-v7a	7,698,293	+0
android	jsc	x86	9,029,584	+0
android	jsc	x86_64	9,507,429	+0

Base commit: e11cfe9
Branch: main

leotm

likely follow-up w related non-deprecated changes: #32980

react-native/.circleci/config.yml

Line 42 in c5a8425

nodelts_image: &nodelts_image "cimg/node:16.14"

react-native/.circleci/config.yml

Line 565 in c5a8425

echo 'export PATH=/usr/local/opt/node@16/bin:$PATH' >> $BASH_ENV

analysis-bot · 2022-11-23T16:10:14Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: e11cfe9
Branch: main

pull-bot · 2022-11-23T16:20:31Z

PR build artifact for d4ecaee is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

cortinico · 2022-11-23T16:43:31Z

I think we can do that, but you'll have to also update the Node version on CircleCI and make sure that everythign is green:
https://github.com/facebook/react-native/blob/main/.circleci/config.yml#L42-L43

Prev-LTS should be 16, and current should be 18.

cortinico

(see my previous comment)

pull-bot · 2022-11-23T23:11:30Z

PR build artifact for e26ef04 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

kelset · 2022-11-25T10:33:59Z

can you fix the changelog entry? [Javascript] is not a valid argument?

leotm · 2022-11-25T12:34:04Z

looks valid/appropriate no? so it's passing

react-native/packages/react-native-bots/dangerfile.js

Line 62 in 55b09da

    
           /\[\s?(ANDROID|GENERAL|IOS|JS|JAVASCRIPT|INTERNAL)\s?\]\s?\[\s?(ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY)\s?\]\s*?-?\s*?(.*)/gi;

if js/javascript been deprecated, happy to create another PR to remove both opts and update to [General]

facebook-github-bot · 2022-11-25T12:38:08Z

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

kelset · 2022-11-25T13:03:27Z

looks valid/appropriate no? so it's passing

react-native/packages/react-native-bots/dangerfile.js

Line 62 in 55b09da

/\[\s?(ANDROID|GENERAL|IOS|JS|JAVASCRIPT|INTERNAL)\s?\]\s?\[\s?(ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY)\s?\]\s*?-?\s*?(.*)/gi;

if js/javascript been deprecated, happy to create another PR to remove both opts and update to [General]

oh wow then the docs are outdated 😅 https://reactnative.dev/contributing/changelogs-in-pull-requests <- that one will need to be fixed; thanks for spotting!

react-native-bot · 2022-11-25T14:50:07Z

This pull request was successfully merged by @leotm in f75b92a.

^{When will my fix make it into a release? | Upcoming Releases}

…PR template (#35541) Summary: A few days back leotm pointed out how the dangerfile was disaligned with the docs around the valid changelog entries for categories and types here: #35443 (comment) I dug a bit deeper into the whole thing and went to the source of truth, which is the changelog generator, in particular here: https://github.com/microsoft/rnx-kit/blob/main/incubator/rn-changelog-generator/src/utils/getChangeDimensions.ts So I've updated the dangerfile to respect the options listed there. Also did a parallel PR on the website side: facebook/react-native-website#3447 So now all comms will be aligned. ## Changelog  [INTERNAL] [FIXED] - fix changelog entries for dangerfiles and PR template Pull Request resolved: #35541 Test Plan: N/A Reviewed By: sammy-SC Differential Revision: D41686913 Pulled By: cortinico fbshipit-source-id: 2297b4a3209188bda4a609b60860de35c5e7e6df

Summary: Pull Request resolved: facebook#37709 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: yungsters Differential Revision: D46462639 fbshipit-source-id: c8db22bbbc8b3158cdf89e88114bee7aed188c12

Summary: Pull Request resolved: facebook#37709 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: yungsters Differential Revision: D46462639 fbshipit-source-id: 57399162a70030c56a2ead370e92a579b6105df2

Summary: ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16's EOL is 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ - this follows up by formally making Node 18 the minimum supported version. Docs PR: facebook/react-native-website#3748 Changelog: [General][Breaking] Bump minimum Node JS version to 18 Differential Revision: D46462639 fbshipit-source-id: 1f7d40f3753a88c1b284dc8cfc0a61084e9de8f5

Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: cortinico, NickGerleman Differential Revision: D46583997 fbshipit-source-id: 4041dd0a4b6bb94eeccc9b4a685d5fca06ab5175

Summary: Pull Request resolved: facebook#37709 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: yungsters Differential Revision: D46462639 fbshipit-source-id: 5007ca540bdcd478956d21cab405f805113b0264

Summary: Pull Request resolved: facebook#37709 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: yungsters Differential Revision: D46462639 fbshipit-source-id: 928e07deaeb32eeb8615d85174ae61be0de4b998

Summary: ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16's EOL is 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ - this follows up by formally making Node 18 the minimum supported version. Docs PR: facebook/react-native-website#3748 Changelog: [General][Breaking] Bump minimum Node JS version to 18 Differential Revision: D46462639 fbshipit-source-id: 372b07647d7578d9e8276f4426adf0583310c46d

Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: cortinico, NickGerleman Differential Revision: D46583997 fbshipit-source-id: 2d21d9283eca7109e9f4593bf60931f5ffc9ee56

Summary: Pull Request resolved: facebook#37709 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: yungsters Differential Revision: D46462639 fbshipit-source-id: b1f7bedde653cd47ffce55875ce5532db4e9ad63

Summary: ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16's EOL is 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ - this follows up by formally making Node 18 the minimum supported version. Docs PR: facebook/react-native-website#3748 Changelog: [General][Breaking] Bump minimum Node JS version to 18 Differential Revision: D46462639 fbshipit-source-id: cb9fcd600be5bc6cc47657b1f9dc87d01c7a2a2a

Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: cortinico, NickGerleman Differential Revision: D46583997 fbshipit-source-id: aa67de9670deb67dd2ab4c064cc074cade36a030

Summary: Pull Request resolved: facebook#37709 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: yungsters Differential Revision: D46462639 fbshipit-source-id: 8eb42fc009e55d6262b12e817bf8f7535054fbf3

Summary: Pull Request resolved: facebook#37709 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: yungsters Differential Revision: D46462639 fbshipit-source-id: 4d02982b86da00d3df8c627d41c5401444370663

Summary: Pull Request resolved: facebook#37709 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: yungsters Differential Revision: D46462639 fbshipit-source-id: 95d513197385bc993af49038aed11c4c082b5b77

Summary: ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16's EOL is 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ - this follows up by formally making Node 18 the minimum supported version. Docs PR: facebook/react-native-website#3748 Changelog: [General][Breaking] Bump minimum Node JS version to 18 Differential Revision: D46462639 fbshipit-source-id: 1b2ab0b9646a8aee0c66149deaa14d417eeb0b45

Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: cortinico, NickGerleman Differential Revision: D46583997 fbshipit-source-id: b6fb7d884a885d1913a281e4ac5af830ab4bed4e

Summary: Pull Request resolved: #37709 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In #35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: yungsters Differential Revision: D46462639 fbshipit-source-id: d3b607788f596e8b5a9c4a6855d3b2f4bafe9a7a

Summary: Pull Request resolved: #37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In #35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: cortinico, NickGerleman Differential Revision: D46583997 fbshipit-source-id: 1f31e2f205ac8b09494c2a7d3b73b9f36eff221b

Summary: Pull Request resolved: facebook/react-native#37709 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook/react-native#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: yungsters Differential Revision: D46462639 fbshipit-source-id: d3b607788f596e8b5a9c4a6855d3b2f4bafe9a7a Original: facebook/react-native@43a6ea9

Summary: Pull Request resolved: facebook/react-native#37709 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook/react-native#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: yungsters Differential Revision: D46462639 fbshipit-source-id: d3b607788f596e8b5a9c4a6855d3b2f4bafe9a7a Original-Commit: facebook/react-native@43a6ea9

Bump .node-version to 18

326521c

Node 18: https://nodejs.org/de/blog/announcements/v18-release-announce/ Node 16 EOL: 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ Node 18 EOL: 2025-04-30 Ref - react-native-community/docker-android#187 cc @ramonmedel @cortinico @gengjiawen

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 23, 2022

Bump template .node-version to 18

d4ecaee

leotm commented Nov 23, 2022

View reviewed changes

cortinico requested changes Nov 23, 2022

View reviewed changes

cortinico mentioned this pull request Nov 23, 2022

[core] circleci node image updated #35404

Closed

leotm changed the title ~~Bump .node-version to 18~~ Bump node-version from 16 to 18 Nov 23, 2022

leotm changed the title ~~Bump node-version from 16 to 18~~ Bump node version from 16 to 18 Nov 23, 2022

leotm added 3 commits November 23, 2022 22:30

Bump CircleCI nodelts_image from 16.14 to 18.12.1

f5ec16e

Bump CircleCI nodeprevlts_image from 14.19 to 16.18.1

77183a6

Bump CircleCI bash env path from node@16 to node@18

e26ef04

leotm requested a review from cortinico November 23, 2022 23:39

cortinico approved these changes Nov 25, 2022

View reviewed changes

facebook-github-bot closed this in f75b92a Nov 25, 2022

cortinico mentioned this pull request Nov 25, 2022

Bump node version react-native-community/docker-android#187

Closed

react-native-bot added the Merged This PR has been merged. label Nov 25, 2022

leotm mentioned this pull request Nov 28, 2022

Changelogs in Pull Requests categories OOD facebook/react-native-website#3435

Closed

kelset mentioned this pull request Dec 2, 2022

fix(internal, dangerfile): fix changelog entries for dangerfiles and PR template #35541

Closed

cipolleschi mentioned this pull request Aug 16, 2023

cipolleschi/add maven polling #39039

Merged

cipolleschi mentioned this pull request Sep 21, 2023

[LOCAL] Copy hermes ruby files to hermes folder in local E2E test #39577

Merged

cipolleschi mentioned this pull request Oct 11, 2023

cipolleschi/fix CI #40793

Merged

cipolleschi mentioned this pull request Nov 1, 2023

[RN][CI]Update node installation on debian (0.71) #41277

Merged

This was referenced Jan 8, 2024

[0.71][RN][General] Migrate boost download url away from JFrog #42177

Merged

[RN][iOS] Fix symbol not found _jump_fcontext with use_frameworks! #42229

Merged

cipolleschi mentioned this pull request Mar 6, 2024

[RN][iOS][0.71] Fix flipper for Xcode 15.3 #43345

Merged

cipolleschi mentioned this pull request Apr 5, 2024

cipolleschi/fix yoga archive 0.71 #43895

Closed

cipolleschi mentioned this pull request Apr 26, 2024

[iOS][Privacy Manifest] Set up privacy manifest for React Native 0.71 #44281

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump node version from 16 to 18 #35443

Bump node version from 16 to 18 #35443

leotm commented Nov 23, 2022 •

edited

Loading

analysis-bot commented Nov 23, 2022 •

edited

Loading

leotm left a comment •

edited

Loading

analysis-bot commented Nov 23, 2022 •

edited

Loading

pull-bot commented Nov 23, 2022

cortinico commented Nov 23, 2022

cortinico left a comment

pull-bot commented Nov 23, 2022

kelset commented Nov 25, 2022

leotm commented Nov 25, 2022 •

edited

Loading

facebook-github-bot commented Nov 25, 2022

kelset commented Nov 25, 2022

react-native-bot commented Nov 25, 2022

Bump node version from 16 to 18 #35443

Bump node version from 16 to 18 #35443

Conversation

leotm commented Nov 23, 2022 • edited Loading

Summary

Changelog

Test Plan

Follow-up

analysis-bot commented Nov 23, 2022 • edited Loading

leotm left a comment • edited Loading

Choose a reason for hiding this comment

analysis-bot commented Nov 23, 2022 • edited Loading

pull-bot commented Nov 23, 2022

cortinico commented Nov 23, 2022

cortinico left a comment

Choose a reason for hiding this comment

pull-bot commented Nov 23, 2022

kelset commented Nov 25, 2022

leotm commented Nov 25, 2022 • edited Loading

facebook-github-bot commented Nov 25, 2022

kelset commented Nov 25, 2022

react-native-bot commented Nov 25, 2022

leotm commented Nov 23, 2022 •

edited

Loading

analysis-bot commented Nov 23, 2022 •

edited

Loading

leotm left a comment •

edited

Loading

analysis-bot commented Nov 23, 2022 •

edited

Loading

leotm commented Nov 25, 2022 •

edited

Loading