Merge main into next (post 0.28.0)#1291
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ralph Khreish <35776126+Crunchyman-ralph@users.noreply.github.com>
|
WalkthroughRemoves multiple .changeset entries and pre.json, updates changelog content across packages, and adjusts package.json versions. Adds initial changelog for @tm/ai-sdk-provider-grok-cli and introduces empty "version" fields in several package.json files. Finalizes root and extension versions and increments docs package version. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (30)
.changeset/brave-lions-sing.md(0 hunks).changeset/chore-fix-docs.md(0 hunks).changeset/cursor-slash-commands.md(0 hunks).changeset/curvy-weeks-flow.md(0 hunks).changeset/easy-spiders-wave.md(0 hunks).changeset/fix-mcp-connection-errors.md(0 hunks).changeset/fix-mcp-default-tasks-path.md(0 hunks).changeset/flat-cities-say.md(0 hunks).changeset/forty-tables-invite.md(0 hunks).changeset/gentle-cats-dance.md(0 hunks).changeset/mcp-timeout-configuration.md(0 hunks).changeset/petite-ideas-grab.md(0 hunks).changeset/pre.json(0 hunks).changeset/silly-pandas-find.md(0 hunks).changeset/sweet-maps-rule.md(0 hunks).changeset/whole-pigs-say.md(0 hunks)CHANGELOG.md(1 hunks)apps/cli/CHANGELOG.md(1 hunks)apps/cli/package.json(1 hunks)apps/docs/CHANGELOG.md(1 hunks)apps/docs/package.json(1 hunks)apps/extension/CHANGELOG.md(1 hunks)apps/extension/package.json(1 hunks)package.json(1 hunks)packages/ai-sdk-provider-grok-cli/CHANGELOG.md(1 hunks)packages/ai-sdk-provider-grok-cli/package.json(1 hunks)packages/build-config/CHANGELOG.md(1 hunks)packages/build-config/package.json(1 hunks)packages/tm-core/CHANGELOG.md(1 hunks)packages/tm-core/package.json(1 hunks)
💤 Files with no reviewable changes (16)
- .changeset/chore-fix-docs.md
- .changeset/brave-lions-sing.md
- .changeset/sweet-maps-rule.md
- .changeset/curvy-weeks-flow.md
- .changeset/pre.json
- .changeset/silly-pandas-find.md
- .changeset/petite-ideas-grab.md
- .changeset/fix-mcp-default-tasks-path.md
- .changeset/forty-tables-invite.md
- .changeset/fix-mcp-connection-errors.md
- .changeset/cursor-slash-commands.md
- .changeset/flat-cities-say.md
- .changeset/whole-pigs-say.md
- .changeset/easy-spiders-wave.md
- .changeset/mcp-timeout-configuration.md
- .changeset/gentle-cats-dance.md
🧰 Additional context used
📓 Path-based instructions (1)
package.json
📄 CodeRabbit inference engine (.cursor/rules/test_workflow.mdc)
Add and update test scripts in package.json to include test, test:watch, test:coverage, test:unit, test:integration, test:e2e, and test:ci
Files:
package.json
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: CLAUDE.md:0-0
Timestamp: 2025-10-07T18:09:26.636Z
Learning: Applies to {CLAUDE.md,.taskmaster/CLAUDE.md} : Import Task Master's development workflow commands and guidelines, treating .taskmaster/CLAUDE.md as if it were included in the main CLAUDE.md
Learnt from: Crunchyman-ralph
PR: eyaltoledano/claude-task-master#1286
File: apps/cli/src/utils/auto-update.ts:63-110
Timestamp: 2025-10-10T16:52:51.383Z
Learning: In the claude-task-master repository, the main branch always contains the latest released code due to automatic CI releases when changes are merged. The next branch contains unreleased changes. This means main branch = latest release.
🪛 markdownlint-cli2 (0.18.1)
packages/tm-core/CHANGELOG.md
5-5: Multiple headings with the same content
(MD024, no-duplicate-heading)
CHANGELOG.md
30-30: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
37-37: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
43-43: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
packages/build-config/CHANGELOG.md
5-5: Multiple headings with the same content
(MD024, no-duplicate-heading)
apps/cli/CHANGELOG.md
10-10: Multiple headings with the same content
(MD024, no-duplicate-heading)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: typecheck
- GitHub Check: build
- GitHub Check: Test
| }, | ||
| "version": "" | ||
| } |
There was a problem hiding this comment.
Empty version string blocks installs
An empty string is not valid semver, so npm/pnpm will fail (Invalid version: "") when processing this workspace. Please remove the field or populate it with the correct release number.
- }
- },
- "version": ""
+ }
+ }Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In apps/cli/package.json around lines 51 to 53 the "version" field is an empty
string which is invalid semver and prevents installs; either remove the
"version" field entirely (so it inherits workspace root/version) or set it to a
valid semver value (e.g., "1.0.0") before committing, and ensure package.json
remains valid JSON.
| # @tm/ai-sdk-provider-grok-cli | ||
|
|
||
| ## null |
There was a problem hiding this comment.
Replace ## null with a real release heading.
The changelog entry was scaffolded but never populated—## null is invalid and will confuse release tooling/readers. Please swap in the actual version (or remove the section until you have content) before landing.
🤖 Prompt for AI Agents
In packages/ai-sdk-provider-grok-cli/CHANGELOG.md around lines 1 to 3, the
changelog contains a placeholder header "## null" which is invalid; replace "##
null" with an actual release heading (e.g., "## vX.Y.Z - YYYY-MM-DD") or remove
the section entirely until you have real release notes, ensuring the top-level
package title remains and the changelog conforms to your release tooling's
expected format.
| }, | ||
| "version": "" | ||
| } |
There was a problem hiding this comment.
Set version to a valid semver (empty string breaks npm).
Adding "version": "" renders this package.json invalid—npm validates the field and rejects empty strings. Either supply the actual release (e.g. "0.0.0") or drop the field until you have a real version. As written, publishing and tooling will fail.
🤖 Prompt for AI Agents
In packages/ai-sdk-provider-grok-cli/package.json around lines 34 to 36, the
"version" field is an empty string which is invalid; replace it with a valid
semver (for example "0.0.0" or the actual release version) or remove the
"version" entry entirely until you have a proper version to publish so
npm/tooling will accept the package.json.
| ## null | ||
|
|
There was a problem hiding this comment.
Remove the extra ## null entry.
This duplicates the existing ## null heading, tripping markdownlint (MD024) and cluttering the changelog. Please drop the redundant section or rename it to the intended version.
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
5-5: Multiple headings with the same content
(MD024, no-duplicate-heading)
🤖 Prompt for AI Agents
In packages/build-config/CHANGELOG.md around lines 5 to 6 there is a redundant
"## null" heading; remove the extra "## null" entry or rename it to the intended
version header so the changelog contains a single correct section heading
(ensuring markdownlint MD024 is resolved).
| }, | ||
| "version": "" | ||
| } |
There was a problem hiding this comment.
"version": "" is invalid semver
Leaving the version as an empty string causes npm/pnpm validation to fail (Invalid version: ""), so the workspace can’t be installed or published. Drop the field or set it to the intended semver before merging.
- "dependencies": {
- "tsup": "^8.5.0"
- },
- "version": ""
+ "dependencies": {
+ "tsup": "^8.5.0"
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| }, | |
| "version": "" | |
| } | |
| "dependencies": { | |
| "tsup": "^8.5.0" | |
| } | |
| } |
🤖 Prompt for AI Agents
In packages/build-config/package.json around lines 27 to 29, the "version": ""
entry is invalid semver and breaks npm/pnpm installs; either remove the
"version" field entirely (so the workspace manager provides the version) or
replace the empty string with the intended valid semver (e.g., "1.0.0"); ensure
the package.json stays valid JSON and update any workspace/versioning scripts or
changelogs that expect a specific version if you choose to set a value.
| ## null | ||
|
|
There was a problem hiding this comment.
Drop the duplicate ## null heading.
We already have a ## null section above; adding a second one breaks markdownlint (MD024) and produces confusing structure. Please remove the duplicate or replace with the intended version heading.
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
5-5: Multiple headings with the same content
(MD024, no-duplicate-heading)
🤖 Prompt for AI Agents
In packages/tm-core/CHANGELOG.md around lines 5 to 6, there's a duplicate
heading "## null" that breaks markdownlint (MD024) and confuses the document;
remove the second "## null" heading (or replace it with the correct version
heading if a specific release/version was intended) so only a single, correct
version heading remains and the changelog structure is valid.
| "license": "MIT", | ||
| "version": "" | ||
| } |
There was a problem hiding this comment.
Invalid empty version value
Setting "version": "" violates npm’s semver requirement; npm/pnpm will reject the package (Invalid version: ""), breaking installs for this workspace. Either drop the field or set it to the actual release version before merging.
- "license": "MIT",
- "version": ""
+ "license": "MIT"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "license": "MIT", | |
| "version": "" | |
| } | |
| "license": "MIT" | |
| } |
🤖 Prompt for AI Agents
In packages/tm-core/package.json around lines 45 to 47, the "version" field is
an empty string which violates npm semver and will cause installs to fail;
remove the "version" field entirely if this package is managed by the
monorepo/publish tooling, or set it to a valid semver string (e.g., "1.2.3" or
the correct release version) before merging so package managers accept the
package.
This PR was automatically generated to update documentation based on recent changes. Original commit: Merge pull request #1291 from eyaltoledano/raplh/chore/merge.main\n\n\n Co-authored-by: Claude <claude-assistant@anthropic.com>
1 participant
Co-authored-by: Claude noreply@anthropic.com# What type of PR is this?
Description
Related Issues
How to Test This
# Example commands or stepsExpected result:
Contributor Checklist
npm run changesetnpm testnpm run format-check(ornpm run formatto fix)Changelog Entry
For Maintainers
Summary by CodeRabbit
Documentation
Chores