fix: remove deprecated generateTaskFiles calls from MCP tools#1277
fix: remove deprecated generateTaskFiles calls from MCP tools#1277Crunchyman-ralph merged 3 commits intonextfrom
Conversation
Removed generateTaskFiles() calls from add_subtask, remove_subtask, and move_task functions to fix MCP connection errors. The generateTaskFiles functionality is no longer supported and was causing "Cannot read properties of null (reading 'toString')" errors when the tag parameter was null/undefined. Fixes: - scripts/modules/task-manager/add-subtask.js: removed generateTaskFiles call and import - scripts/modules/task-manager/remove-subtask.js: removed generateTaskFiles call and import - scripts/modules/task-manager/move-task.js: removed generateTaskFiles calls and import Resolves issue #1271 - MCP Connection Closed Error After Upgrading to v0.27.3 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Ralph Khreish <Crunchyman-ralph@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 8dde2aa The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughRemoved calls and imports for generateTaskFiles (and unused path) from add-subtask, move-task, and remove-subtask; tests updated to remove expectations for generation. Added a changeset documenting MCP connection errors caused by deprecated generation calls. Core task read/write and public APIs unchanged. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant C as Caller
participant TM as TaskManager (Before)
participant FS as FileStore
participant FG as FileGen
Note over TM,FG: Previous flow (with generation)
C->>TM: add/move/remove
TM->>FS: read/update/write JSON
TM->>FG: generateTaskFiles()
FG-->>TM: done
TM-->>C: result
sequenceDiagram
autonumber
participant C as Caller
participant TM as TaskManager (Now)
participant FS as FileStore
Note over TM: Current flow (no generation)
C->>TM: add/move/remove
TM->>FS: read/update/write JSON
TM-->>C: result
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Comment |
|
@claude please add a changeset in .changeset |
|
Claude finished @Crunchyman-ralph's task —— View job Tasks
Changeset AddedI've created and committed a changeset file (
The changeset will be processed during the next release to automatically update the version and generate release notes. |
Co-authored-by: Ralph Khreish <Crunchyman-ralph@users.noreply.github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
.changeset/fix-mcp-connection-errors.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
.changeset/*.md
📄 CodeRabbit inference engine (.cursor/rules/changeset.mdc)
.changeset/*.md: When runningnpm run changesetornpx changeset add, provide a concise summary of the changes for theCHANGELOG.mdin imperative mood, typically a single line, and not a detailed Git commit message.
The changeset summary should be user-facing, describing what changed in the released version that is relevant to users or consumers of the package.
Do not use your detailed Git commit message body as the changeset summary.
Files:
.changeset/fix-mcp-connection-errors.md
.changeset/*
📄 CodeRabbit inference engine (.cursor/rules/new_features.mdc)
Create appropriate changesets for new features, use semantic versioning, include tagged system information in release notes, and document breaking changes if any.
Files:
.changeset/fix-mcp-connection-errors.md
🧠 Learnings (2)
📚 Learning: 2025-09-24T15:12:58.855Z
Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: assets/AGENTS.md:0-0
Timestamp: 2025-09-24T15:12:58.855Z
Learning: Applies to assets/**/.mcp.json : Configure the Task Master MCP server in .mcp.json under mcpServers.task-master-ai using npx task-master-ai and provide required API key env vars
Applied to files:
.changeset/fix-mcp-connection-errors.md
📚 Learning: 2025-07-17T21:33:57.585Z
Learnt from: Crunchyman-ralph
PR: eyaltoledano/claude-task-master#1002
File: .changeset/puny-friends-give.md:2-3
Timestamp: 2025-07-17T21:33:57.585Z
Learning: In the eyaltoledano/claude-task-master repository, the MCP server code in mcp-server/src/ is part of the main "task-master-ai" package, not a separate "mcp-server" package. When creating changesets for MCP server changes, use "task-master-ai" as the package name.
Applied to files:
.changeset/fix-mcp-connection-errors.md
🪛 markdownlint-cli2 (0.18.1)
.changeset/fix-mcp-connection-errors.md
5-5: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
5-5: Files should end with a single newline character
(MD047, single-trailing-newline)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
| "task-master-ai": patch | ||
| --- | ||
|
|
||
| Fix MCP connection errors caused by deprecated generateTaskFiles calls. Resolves "Cannot read properties of null (reading 'toString')" errors when using MCP tools for task management operations. No newline at end of file |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
Make the changeset summary single-sentence imperative and add trailing newline.
Per the repo’s changeset guidelines, keep the entry to a concise, imperative single line. Also ensure the file ends with a newline to clear MD047. Suggested rewrite: “Fix MCP connection errors when MCP task tools called deprecated generateTaskFiles.”
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
5-5: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
5-5: Files should end with a single newline character
(MD047, single-trailing-newline)
🤖 Prompt for AI Agents
.changeset/fix-mcp-connection-errors.md around line 5: the changeset summary
must be a single, imperative sentence and the file must end with a newline;
replace the current line with the concise imperative sentence "Fix MCP
connection errors when MCP task tools call deprecated generateTaskFiles." and
ensure the file ends with a trailing newline character.
This PR was automatically generated to update documentation based on recent changes. Original commit: fix: remove deprecated generateTaskFiles calls from MCP tools (#1277)\n\nCo-authored-by: Ralph Khreish <Crunchyman-ralph@users.noreply.github.com>\nCo-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>\nResolves issue #1271 - MCP Connection Closed Error After Upgrading to v0.27.3\n\n Co-authored-by: Claude <claude-assistant@anthropic.com>
…ledano#1277) Co-authored-by: Ralph Khreish <Crunchyman-ralph@users.noreply.github.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Resolves issue eyaltoledano#1271 - MCP Connection Closed Error After Upgrading to v0.27.3
1 participant
Removed generateTaskFiles() calls from add_subtask, remove_subtask, and move_task functions to fix MCP connection errors. The generateTaskFiles functionality is no longer supported and was causing "Cannot read properties of null (reading 'toString')" errors.
Fixes issue #1271 - MCP Connection Closed Error After Upgrading to v0.27.3
Generated with Claude Code
Summary by CodeRabbit