fix: remove invalid empty version fields from workspace packages#1333
fix: remove invalid empty version fields from workspace packages#1333Crunchyman-ralph merged 1 commit intomainfrom
Conversation
|
WalkthroughRemoved empty top-level "version" fields from several package.json manifests and removed Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/ai-sdk-provider-grok-cli/package.json (1)
32-34: Minor observation: Verify publishConfig intent for private package.This package is marked
"private": truebut haspublishConfig.access: "public". While this may be intentional (the publishConfig is only consulted during publish attempts), confirm this is the desired configuration. This is unrelated to the current PR but worth verifying.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
apps/cli/package.json(1 hunks)apps/mcp/package.json(0 hunks)packages/ai-sdk-provider-grok-cli/package.json(1 hunks)packages/build-config/package.json(1 hunks)packages/tm-core/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- apps/mcp/package.json
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Crunchyman-ralph
PR: eyaltoledano/claude-task-master#1232
File: packages/tm-core/package.json:50-51
Timestamp: 2025-09-22T19:45:04.337Z
Learning: In the eyaltoledano/claude-task-master project, Crunchyman-ralph intentionally omits version fields from internal/private packages in package.json files to prevent changesets from releasing new versions of these packages while still allowing them to be processed for dependency updates. The changesets warnings about missing versions are acceptable as they don't break the process and achieve the desired behavior of only releasing public packages.
Learnt from: Crunchyman-ralph
PR: eyaltoledano/claude-task-master#1232
File: packages/build-config/package.json:14-15
Timestamp: 2025-09-22T19:45:13.323Z
Learning: In the eyaltoledano/claude-task-master repository, Crunchyman-ralph intentionally omits version fields from internal packages (like tm/build-config) to prevent changesets from releasing new versions for these packages. This is the desired behavior for internal tooling packages that should not be published or versioned independently.
📚 Learning: 2025-09-22T19:45:04.337Z
Learnt from: Crunchyman-ralph
PR: eyaltoledano/claude-task-master#1232
File: packages/tm-core/package.json:50-51
Timestamp: 2025-09-22T19:45:04.337Z
Learning: In the eyaltoledano/claude-task-master project, Crunchyman-ralph intentionally omits version fields from internal/private packages in package.json files to prevent changesets from releasing new versions of these packages while still allowing them to be processed for dependency updates. The changesets warnings about missing versions are acceptable as they don't break the process and achieve the desired behavior of only releasing public packages.
Applied to files:
packages/build-config/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (4)
packages/build-config/package.json (1)
14-27: Metadata cleanup is correct and aligns with workspace configuration.Removing the empty
versionfield from this private package allows the workspace protocol to manage versioning automatically, which resolves the changesets validation error. This is consistent with your prior design decisions for internal packages.apps/cli/package.json (1)
42-52: Correct metadata removal for private package.The empty
versionfield has been cleanly removed. Note that this package already declares the correct workspace dependency protocol for@tm/core(line 26 uses"*"), so this change resolves the validation error reported in the PR description.packages/tm-core/package.json (1)
46-49: License metadata added and version field removed correctly.Adding
"license": "MIT"improves metadata transparency for this core package. The removal of the emptyversionfield allows workspace versioning to apply, resolving the changesets validation error. Both changes are metadata-only and do not affect the module's exports or runtime behavior.packages/ai-sdk-provider-grok-cli/package.json (1)
27-34: Workspace metadata update is correct.Removing the empty
versionfield from this private package resolves the changesets validation error mentioned in the PR description. The file structure is valid and consistent with other updated packages.
cd8d7b4 to
f98e0db
Compare
Removes `"version": ""` from internal workspace packages to fix changesets validation errors. These private packages don't need explicit version fields as they use workspace protocol. Fixes validation errors: - Package "task-master-ai" must depend on the current version of "@tm/ai-sdk-provider-grok-cli": "" vs "*" - Package "task-master-ai" must depend on the current version of "@tm/cli": "" vs "*" - Package "@tm/cli" must depend on the current version of "@tm/core": "" vs "*" - Package "extension" must depend on the current version of "@tm/core": "" vs "*" - Package "@tm/mcp" must depend on the current version of "@tm/core": "" vs "*" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
f98e0db to
2d988a1
Compare
What type of PR is this?
Description
Removes
"version": ""from internal workspace packages to fixchangesets validation errors. These private packages don't need
explicit version fields as they use workspace protocol.
Fixes validation errors:
Related Issues
How to Test This
# Example commands or stepsExpected result:
Contributor Checklist
npm run changesetnpm testnpm run format-check(ornpm run formatto fix)Changelog Entry
For Maintainers
Summary by CodeRabbit