Skip to content

Fix more configlet links #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix more configlet links #160

wants to merge 1 commit into from

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Jun 24, 2021

I was expecting these links to work after #159.

But if you go to https://exercism.lol/docs/building/configlet, it contains e.g.:

How these documents are generated can be found here

where the links go to e.g.
https://exercism.lol/docs/building/generating-documents (broken)
rather than
https://exercism.lol/docs/building/configlet/generating-documents

So I've tried to fix this by adding configlet/. Is this what we want?

This feels weird to me because README.md is in the building/configlet directory - I was expecting ./ in this file to be relative to the building/configlet directory, not the building directory.

When I understand better I'll also push a commit to this PR for some broken links in generating-documents.

@iHiD
Copy link
Member

iHiD commented Jun 24, 2021

I think this is correct.

To be clear, this is just web-links, not any magic I'm doing.

/configlet is treated as a webpage. ./ is the directory the webpage is in (from a browser perspective). So ./configlet/uuid makes sense in terms of saying the uuid webpage in the configlet directory relative to the configlet webpage.

I alwaysy find it confusing to get right too :)

@ee7 ee7 mentioned this pull request Jul 22, 2021
@ee7
Copy link
Member Author

ee7 commented Aug 30, 2021

Closing - Erik fixed all these in #200.

@ee7 ee7 closed this Aug 30, 2021
@ee7 ee7 deleted the fix-more-links branch August 30, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants