Skip to content

Document key feature icons #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 23, 2021
Merged

Document key feature icons #186

merged 6 commits into from
Jul 23, 2021

Conversation

ErikSchierboom
Copy link
Member

@ErikSchierboom ErikSchierboom commented Jul 22, 2021 •
edited
Loading

CC @ee7

ErikSchierboom added a commit to exercism/configlet that referenced this pull request Jul 22, 2021
@ErikSchierboom
lint(track_config): check key feature icons
5f7f542 
This commit enables checking the key feature icons against the list of
allowed icons.

See also:
- exercism/docs#186, which defines the list of
  key feature icons
@ErikSchierboom ErikSchierboom mentioned this pull request Jul 22, 2021
Merged
@ErikSchierboom ErikSchierboom requested a review from iHiD July 22, 2021 14:49
iHiD
iHiD approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@iHiD iHiD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve and you can merge in the morning if ee7 doesn't get chance to look before then :)

ee7
ee7 reviewed Jul 22, 2021
View reviewed changes
ErikSchierboom and others added 3 commits July 23, 2021 07:50
@ErikSchierboom @ee7
Update building/configlet/lint.md
bb71a82 
Co-authored-by: ee7 <45465154+ee7@users.noreply.github.com>
@ErikSchierboom @ee7
Update building/tracks/config-json.md
9e8af83 
Co-authored-by: ee7 <45465154+ee7@users.noreply.github.com>
@ErikSchierboom @ee7
Update building/tracks/config-json.md
3043114 
Co-authored-by: ee7 <45465154+ee7@users.noreply.github.com>
@ErikSchierboom ErikSchierboom mentioned this pull request Jul 23, 2021
Merged
ErikSchierboom and others added 2 commits July 23, 2021 08:29
@ErikSchierboom
Update names of icons
7d86b11
@ErikSchierboom @ee7
Update building/tracks/config-json.md
e050295 
Co-authored-by: ee7 <45465154+ee7@users.noreply.github.com>
ErikSchierboom added a commit to exercism/configlet that referenced this pull request Jul 23, 2021
@ErikSchierboom
lint(track_config): check key feature icons
f27c9da 
This commit enables checking the key feature icons against the list of
allowed icons.

See also:
- exercism/docs#186, which defines the list of
  key feature icons
@ErikSchierboom ErikSchierboom requested a review from ee7 July 23, 2021 06:31
@ErikSchierboom
Copy link
Member Author

@ee7 Updated.

ee7
ee7 approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I was going to ask if shrink could be small :)

ErikSchierboom added a commit to exercism/configlet that referenced this pull request Jul 23, 2021
@ErikSchierboom
lint(track_config): check key feature icons (#393)
2e3ef6b 
This commit enables checking the key feature icons against the list of
allowed icons.

See also:
- exercism/docs#186, which defines the list of
  key feature icons
@ErikSchierboom ErikSchierboom merged commit 8998f31 into main Jul 23, 2021
@ErikSchierboom ErikSchierboom deleted the key-feature-icons branch July 23, 2021 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iHiD iHiD iHiD approved these changes

@ee7 ee7 ee7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErikSchierboom @iHiD @ee7