Skip to content

Fix some links in configlet docs #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 24, 2021
Merged

Fix some links in configlet docs #159

merged 6 commits into from
Jun 24, 2021

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Jun 24, 2021

Some of this might be wrong. I don't understand all the implications of #158 (comment) yet.

Edit: Ah. Okay, I'm beginning to see.

@ee7 ee7 marked this pull request as draft June 24, 2021 12:00
@ee7 ee7 force-pushed the fix-some-links branch from 8ef394d to 5803046 Compare June 24, 2021 12:01
@ee7 ee7 marked this pull request as ready for review June 24, 2021 12:09
@ee7
Copy link
Member Author

ee7 commented Jun 24, 2021

Maybe this?

@ee7 ee7 changed the title Fix some links Fix some links in configlet docs Jun 24, 2021
@iHiD
Copy link
Member

iHiD commented Jun 24, 2021

This is really helpful. Thanks :)

@iHiD iHiD requested a review from ErikSchierboom June 24, 2021 12:17
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: ignore

@iHiD iHiD merged commit edfe96b into exercism:main Jun 24, 2021
@ee7 ee7 deleted the fix-some-links branch June 24, 2021 14:07
@@ -4,28 +4,28 @@

## Linting

The primary function of configlet is to do _linting_: checking if a track's configuration files are properly structured - both syntactically and semantically. Misconfigured tracks may not sync correctly, may look wrong on the website, or may present a suboptimal user experience, so configlet's guards play an important part in maintaining the integrity of Exercism. The full list of rules that are checked by the linter can be found [here](./linting.md).
The primary function of configlet is to do _linting_: checking if a track's configuration files are properly structured - both syntactically and semantically. Misconfigured tracks may not sync correctly, may look wrong on the website, or may present a suboptimal user experience, so configlet's guards play an important part in maintaining the integrity of Exercism. The full list of rules that are checked by the linter can be found [here](./lint).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iHiD So this PR got merged and deployed, and when I click this link on https://exercism.lol/docs/building/configlet, I get a 500 error. I'm guessing it's because it tries to take me to https://exercism.lol/docs/building/lint instead of https://exercism.lol/docs/building/configlet/lint

The same is true about some other links that starts with ./.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess @ee7 noticed the same thing at the same time and opened #160 :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this too. I just created #160 to follow up.

@ee7 ee7 mentioned this pull request Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants