Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #8480

Closed
wants to merge 2 commits into from
Closed

Fix typos #8480

wants to merge 2 commits into from

Conversation

descodess
Copy link

  • Fix typos.
  • Improve German and English spelling.

Thank you!

@StefanSchoof
Copy link
Contributor

Language file are primarily maintained at https://hosted.weblate.org/engage/evcc/ and will be sync from there.

@andig andig marked this pull request as draft June 15, 2023 20:21
@andig andig self-requested a review June 15, 2023 20:21
@andig andig self-assigned this Jun 15, 2023
@andig
Copy link
Member

andig commented Jun 16, 2023

@descodess please see comments. I agree with part of the proposed changes, but not with the full set.

i18n/de.toml Show resolved Hide resolved
i18n/de.toml Show resolved Hide resolved
i18n/de.toml Show resolved Hide resolved
i18n/de.toml Show resolved Hide resolved
i18n/de.toml Show resolved Hide resolved
i18n/de.toml Show resolved Hide resolved
i18n/de.toml Show resolved Hide resolved
i18n/de.toml Show resolved Hide resolved
@andig
Copy link
Member

andig commented Jun 16, 2023

/cc @premultiply

@andig andig removed their assignment Jun 16, 2023
i18n/de.toml Show resolved Hide resolved
@naltatis
Copy link
Member

Language file are primarily maintained at https://hosted.weblate.org/engage/evcc/ and will be sync from there.

Yes, only the English source language should be changed with PRs directly in this repository. The German changes should be done through our translation tool to avoid conflicts.

@andig
Copy link
Member

andig commented Jun 17, 2023

Bleibt die Frage: wenden wir durchgängig Duden an und sind insbesodnere die Spaces umsetzbar?

@naltatis
Copy link
Member

naltatis commented Jul 8, 2023

Die die deutschen Weblate Änderungen:
https://github.com/evcc-io/evcc/pull/8868/files

@naltatis naltatis mentioned this pull request Jul 8, 2023
@naltatis
Copy link
Member

naltatis commented Jul 8, 2023

@descodess sorry, dass das hier so lange liegen geblieben ist. Ich bin das gerade noch einmal durchgegangen. Nun müssten alle angesprochenen Punkte adressiert sein. Um Konflikte zu vermeiden hab ich die verbleibenden Änderungen an den Englischen Ausgangstexten in einem neuen PR #8869 gemacht. Falls ich noch was übersehen habe gerne dort ergänzen.

Danke für deine Arbeit! 💚

@naltatis naltatis closed this Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants