Skip to content

Docs addresses #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 5, 2023
Merged

Docs addresses #3014

merged 7 commits into from
Jul 5, 2023

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented Jun 30, 2023

What was wrong?

Closes #2011

How was it fixed?

Replaced addresses in examples that may have risk involved, especially in transactions. Most of the time though, the addresses point to a real (but empty/unused) account.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

for human-readable addresses. If an address is registered with the ENS registry,
the domain name can be used in place of the address itself. For example, the registered domain
name ``ethereum.eth`` will resolve to the address
``0xde0B295669a9FD93d5F28D9Ec85E40f4cb697BAe``. web3.py has support for ENS, documented
Copy link
Contributor Author

@reedsa reedsa Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this to get away from the "sending funds" recommendation 😬

@reedsa reedsa marked this pull request as ready for review June 30, 2023 23:03
@reedsa reedsa requested review from fselmo and wolovim June 30, 2023 23:03
Copy link
Member

@wolovim wolovim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. 'jasoncarver.eth' still appears in some examples, which might be fine, but we could also consider swapping that out for something publicly maintained by ENS or EF. if desirable, fine as a separate PR too.

@reedsa
Copy link
Contributor Author

reedsa commented Jul 5, 2023

Will track replacement of jasoncarver.eth in #3020

@reedsa reedsa merged commit 1ee41c8 into ethereum:main Jul 5, 2023
@fselmo fselmo mentioned this pull request Jul 5, 2023
1 task
@reedsa reedsa deleted the docs-addresses branch March 19, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't include arbitrary addresses in documentation.
3 participants