-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Docs addresses #3014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs addresses #3014
Conversation
…d replace all addresses with variables
…er funds to use a known unused address
for human-readable addresses. If an address is registered with the ENS registry, | ||
the domain name can be used in place of the address itself. For example, the registered domain | ||
name ``ethereum.eth`` will resolve to the address | ||
``0xde0B295669a9FD93d5F28D9Ec85E40f4cb697BAe``. web3.py has support for ENS, documented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this to get away from the "sending funds" recommendation 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. 'jasoncarver.eth' still appears in some examples, which might be fine, but we could also consider swapping that out for something publicly maintained by ENS or EF. if desirable, fine as a separate PR too.
Will track replacement of jasoncarver.eth in #3020 |
What was wrong?
Closes #2011
How was it fixed?
Replaced addresses in examples that may have risk involved, especially in transactions. Most of the time though, the addresses point to a real (but empty/unused) account.
Todo:
Cute Animal Picture