Don't include arbitrary addresses in documentation.

[adam505hq]

One example is https://web3py.readthedocs.io/en/stable/web3.eth.html#web3.eth.Eth.send_raw_transaction. 0xd3CdA913deB6f67967B99D67aCDFa1712C293601 should be replaced with public_address_of_receivers_account.

This is live address that is actually used on mainnet: https://etherscan.io/address/0xd3CdA913deB6f67967B99D67aCDFa1712C293601 . Whether this is accident - I don't know.

[wolovim]

Fair point; PR welcome or I'll get to it next time I'm in the docs.

[divyanshugit]

Hey, @marcgarreau I wanna work on this. Can you please assign this issue to me? It will great If you can provide a little bit more info about this. I think it will be great for me to getting started with ethereum :)

[fselmo]

Can you please assign this issue to me? It will great If you can provide a little bit more info about this. I think it will be great for me to getting started with ethereum :)

Hey @divyanshugit. Thanks for the interest! I went ahead and assigned this to you. For this issue, we would want to replace the address 0xd3CdA913deB6f67967B99D67aCDFa1712C293601, wherever it appears in the code base, with a variable name that is suited for the context in which it is used. For the particular example mentioned in the description of this issue, public_address_of_receivers_account could be suitable. We may, however, need to tweak this variable name a bit depending on the different contexts that you see among the code base.

Hope this helps.

edit: We should just use something simple like account_address, (account_address_2, etc... if there are multiple) unless the context calls for the variable name being a bit more descriptive.

[gupta437]

@divyanshugit Are you still working on this issue? If not I would like to work on it. Appreciate your response in advance!

[kclowes]

@gupta437 feel free to pick it up since there has been no PR in over a month. I'll remove @divyanshugit from the assignees. Let us know if you have questions!

[gupta437]

@kclowes Thankyou! I will pick this up.

[0xrishabh]

@kclowes can't we replace every live address with address_of_account or address?

[abdulqgg]

Hey could i tackle this for my first issue? Thanks

[fselmo]

Hey could i tackle this for my first issue? Thanks

Thanks for the interest, @abdulqgg. Looks like @gupta437 mentioned working on this as of 3 days ago. I would suggest a conversation here with @gupta437 to see how far along they are in order to avoid duplicate work.

[gupta437]

@abdulqgg I also picked this up as my first issue. I am still working on it. I will update you if this would be free to pick up.

[fselmo]

@gupta437 I went ahead and officially assigned it to you to avoid confusion 👍