Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace jasoncarver.eth with ens.eth #3022

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Replace jasoncarver.eth with ens.eth #3022

merged 4 commits into from
Jul 6, 2023

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented Jul 5, 2023

What was wrong?

Closes #3020

How was it fixed?

Use ens.eth instead of jasoncarver.eth

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@reedsa reedsa marked this pull request as ready for review July 5, 2023 20:21
fselmo
fselmo reviewed Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change all the addresses that don't have to do with ENS to one of the spoofed addresses we just used in #2594... so any addresses in ethpm.rst, web3.eth.contract.rst, web3.eth.rst, and web3.geth.rst`

edit: I meant #3014 not #2594 !

docs/ethpm.rst Outdated Show resolved Hide resolved
fselmo
fselmo approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a small nit 👍🏼

docs/ens_overview.rst Outdated Show resolved Hide resolved
pacrob
pacrob approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@reedsa reedsa merged commit 305b3c3 into ethereum:main Jul 6, 2023
@reedsa reedsa deleted the 3020-remove-jasoncarver branch March 19, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fselmo fselmo fselmo approved these changes

@pacrob pacrob pacrob approved these changes

@wolovim wolovim Awaiting requested review from wolovim

@kclowes kclowes Awaiting requested review from kclowes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace references to jasoncarver.eth
3 participants
@reedsa @fselmo @pacrob