[Yul] introduce break/continue keywords. #6136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

christianparpart merged 1 commit into develop from yul-break-continue

Mar 11, 2019

Member

christianparpart commented Feb 28, 2019 •

edited

Loading

This PR implements break and continue keywords in Yul. (refs #4576)

Checklist

code generation for EVM backend (currently just yulAssert()'ting)
interpreter
syntax tests for each keyword

chriseth previously requested changes

View reviewed changes

Contributor

chriseth left a comment

We should be careful not to merge this before the optimizer can cope with it (or at least put assertions in the appropriate places).

libsolidity/analysis/ViewPureChecker.cpp Show resolved Hide resolved

libyul/AsmAnalysis.cpp Show resolved Hide resolved

libyul/AsmParser.cpp Outdated Show resolved Hide resolved

libyul/AsmParser.cpp Outdated Show resolved Hide resolved

libyul/AsmParser.cpp Outdated Show resolved Hide resolved

libyul/AsmPrinter.cpp Outdated Show resolved Hide resolved

libyul/AsmPrinter.cpp Outdated Show resolved Hide resolved

libyul/optimiser/ASTWalker.cpp Outdated Show resolved Hide resolved

libyul/optimiser/SyntacticalEquality.cpp Outdated Show resolved Hide resolved

Member

axic commented Feb 28, 2019

Perhaps to simplify this, as a first step one could add full support to the parser and rejecting it in the analyser. I think that would be safe to merge even now, without the need to update optimisers.

christianparpart force-pushed the yul-break-continue branch 5 times, most recently from 2b2ee2e to 77586e9 Compare

February 28, 2019 13:59

axic reviewed

View reviewed changes

libyul/backends/evm/EVMCodeTransform.cpp Outdated Show resolved Hide resolved

christianparpart force-pushed the yul-break-continue branch from 6d9c530 to 017c1f2 Compare

February 28, 2019 14:23

chriseth reviewed

View reviewed changes

test/tools/yulInterpreter/Interpreter.cpp Show resolved Hide resolved

christianparpart force-pushed the yul-break-continue branch 3 times, most recently from 80e28d4 to 5d6b0f8 Compare

February 28, 2019 15:05

chriseth reviewed

View reviewed changes

libdevcore/Utils.h Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

libdevcore/Utils.h Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

libdevcore/Utils.h Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

libyul/backends/evm/EVMCodeTransform.cpp Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

libyul/backends/evm/EVMCodeTransform.cpp Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

libyul/backends/evm/EVMCodeTransform.cpp Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

libyul/backends/evm/EVMCodeTransform.h Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

test/tools/yulInterpreter/Interpreter.cpp Outdated Show resolved Hide resolved

christianparpart force-pushed the yul-break-continue branch 2 times, most recently from fcd943e to 14ebc1c Compare

March 4, 2019 09:19

This comment has been minimized.

Sign in to view

christianparpart force-pushed the yul-break-continue branch 4 times, most recently from f16fa65 to 88469cb Compare

March 4, 2019 15:10

christianparpart dismissed chriseth’s stale review

March 4, 2019 17:35

done, so far. (more changes still pending, still in WIP-status)

chriseth reviewed

View reviewed changes

libdevcore/Common.h Outdated Show resolved Hide resolved

christianparpart force-pushed the yul-break-continue branch from 23b3cdd to 72fc5f9 Compare

March 6, 2019 15:53

This comment has been minimized.

Sign in to view

chriseth reviewed

View reviewed changes

test/tools/yulInterpreter/Interpreter.cpp Show resolved Hide resolved

chriseth reviewed

View reviewed changes

test/tools/yulInterpreter/Interpreter.cpp Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

test/tools/yulInterpreter/Interpreter.h Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

chriseth reviewed

View reviewed changes

libyul/AsmAnalysis.cpp Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

libyul/AsmAnalysis.cpp Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

libyul/AsmAnalysis.h Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

libyul/AsmParser.cpp Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

libyul/backends/evm/EVMCodeTransform.cpp Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

libyul/backends/evm/EVMCodeTransform.h Outdated Show resolved Hide resolved

christianparpart force-pushed the yul-break-continue branch 4 times, most recently from e211913 to 764f4e4 Compare

March 11, 2019 14:03


          [Yul] Adds break/continue statements and some general tests for for-l…

05e2d36

…oop syntax.

christianparpart force-pushed the yul-break-continue branch 2 times, most recently from 75e7758 to bf17f5f Compare

March 11, 2019 15:22

christianparpart changed the title ~~[WIP] [Yul] introduce break/continue keywords.~~ [Yul] introduce break/continue keywords.

christianparpart mentioned this pull request

Yul codegen for break & continue statements #6241

Merged

3 tasks

chriseth reviewed

View reviewed changes

libyul/optimiser/DataFlowAnalyzer.cpp Outdated Show resolved Hide resolved

chriseth reviewed

View reviewed changes

libyul/optimiser/DataFlowAnalyzer.cpp Outdated Show resolved Hide resolved

christianparpart force-pushed the yul-break-continue branch from bf17f5f to 05e2d36 Compare

March 11, 2019 15:37

chriseth approved these changes

View reviewed changes

christianparpart mentioned this pull request

Yul dataflow analysis for continue/break statements #6242

Merged

christianparpart merged commit cfefa2c into develop

christianparpart deleted the yul-break-continue branch

March 11, 2019 19:39

bshastry mentioned this pull request

yul proto spec: add for and switch...case statements #6224

Closed

bshastry mentioned this pull request

Implement code generation routines for break/continue statements #6387

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet