Yul dataflow analysis for continue/break statements #6242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianparpart
force-pushed
the
yul-bc-dataflow
branch
2 times, most recently
from
a1e6687 to
1247d77
Compare
This comment has been minimized.
This comment has been minimized.
leonardoalt
reviewed
Mar 12, 2019
christianparpart
force-pushed
the
yul-bc-dataflow
branch
4 times, most recently
from
d6f6276 to
099ab29
Compare
chriseth
reviewed
Mar 12, 2019
chriseth
reviewed
Mar 12, 2019
chriseth
reviewed
Mar 12, 2019
chriseth
reviewed
Mar 12, 2019
christianparpart
force-pushed
the
yul-bc-dataflow
branch
2 times, most recently
from
53b820a to
7086402
Compare
This comment has been minimized.
This comment has been minimized.
christianparpart
force-pushed
the
yul-bc-dataflow
branch
from
7086402 to
efbcb59
Compare
leonardoalt
reviewed
Mar 12, 2019
test/libyul/yulOptimizerTests/commonSubexpressionEliminator/for_continue.yul
Outdated
Show resolved
Hide resolved
|
The code vanished because it turned out that we actually do not have to do anything. Would be great if you could verify that, @leonardoalt |
|
Ok I see. It would be nice to have tests showing that. |
christianparpart
force-pushed
the
yul-bc-dataflow
branch
from
efbcb59 to
582cc73
Compare
chriseth
reviewed
Mar 13, 2019
chriseth
reviewed
Mar 13, 2019
christianparpart
force-pushed
the
yul-bc-dataflow
branch
2 times, most recently
from
50cded3 to
86bf721
Compare
chriseth
reviewed
Mar 13, 2019
christianparpart
force-pushed
the
yul-bc-dataflow
branch
from
86bf721 to
29ccbd5
Compare
chriseth
reviewed
Mar 14, 2019
chriseth
reviewed
Mar 14, 2019
chriseth
reviewed
Mar 14, 2019
chriseth
reviewed
Mar 14, 2019
chriseth
reviewed
Mar 14, 2019
chriseth
reviewed
Mar 14, 2019
chriseth
reviewed
Mar 14, 2019
chriseth
reviewed
Mar 14, 2019
| { | ||
| let a | ||
| let b | ||
| for {let i := 0} lt(i, 10) {i := add(a, b) b := origin()} |
There was a problem hiding this comment.
Hm, unfortunately, I don't remember anymore which aspect this was supposed to test..
There was a problem hiding this comment.
@chriseth the motivation behind this, yesterday, was, to test for loops with continue statements modifying a used variable in the post-block (b := origin()). Maybe I should have chosen a different value?
christianparpart
force-pushed
the
yul-bc-dataflow
branch
from
29ccbd5 to
524e133
Compare
chriseth
reviewed
Mar 14, 2019
test/libyul/yulOptimizerTests/rematerialiser/for_continue_with_assignment_in_post.yul
Outdated
Show resolved
Hide resolved
…nts just like without.
christianparpart
force-pushed
the
yul-bc-dataflow
branch
from
524e133 to
57bcb8b
Compare
chriseth
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds data flow analysis for break & continue statements. This PR is rebased on top of #6136.