-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Yul codegen for break & continue statements #6241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
c607ce9
to
1dd3a77
Compare
This comment has been minimized.
This comment has been minimized.
chriseth
previously approved these changes
Mar 11, 2019
1a8bd92
to
5df2b41
Compare
74f0e21
to
306b7e3
Compare
This comment has been minimized.
This comment has been minimized.
306b7e3
to
fb28122
Compare
This comment has been minimized.
This comment has been minimized.
fb28122
to
482d575
Compare
This comment has been minimized.
This comment has been minimized.
482d575
to
ca141ac
Compare
@leonardoalt rebased. it kinda depends on #6315 to be merged first. which is in |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Rebasing on top of #6315 mainly to enable fuzzing both. |
ca141ac
to
5438c76
Compare
Changed PR base. |
e784781
to
6d459ba
Compare
6d459ba
to
91f96c2
Compare
… & ChangeLog entry.
5438c76
to
b8c6274
Compare
chriseth
reviewed
Mar 28, 2019
leonardoalt
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would make sense to merge #6315 first
Closes #4576
It contains the codegen part of Yul's break & continue statements.
Checklist