[1/3] SourceLocation related refactoring. #5537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
reviewed
Nov 29, 2018
chriseth
reviewed
Nov 29, 2018
chriseth
reviewed
Nov 29, 2018
chriseth
reviewed
Nov 29, 2018
added 2 commits
November 29, 2018 12:28
…ame (and adapt codebase to it)
christianparpart
force-pushed
the
cp-SourceLocation-related-refactoring
branch
from
2f8a792 to
f101654
Compare
This comment has been minimized.
This comment has been minimized.
chriseth
reviewed
Nov 29, 2018
chriseth
reviewed
Nov 29, 2018
chriseth
reviewed
Nov 29, 2018
chriseth
reviewed
Nov 29, 2018
chriseth
reviewed
Nov 29, 2018
chriseth
reviewed
Nov 29, 2018
chriseth
reviewed
Nov 29, 2018
chriseth
reviewed
Nov 29, 2018
chriseth
reviewed
Nov 29, 2018
christianparpart
force-pushed
the
cp-SourceLocation-related-refactoring
branch
from
f101654 to
77d43d4
Compare
christianparpart
changed the title
christianparpart
force-pushed
the
cp-SourceLocation-related-refactoring
branch
2 times, most recently
from
2412441 to
d08d3ee
Compare
chriseth
reviewed
Nov 30, 2018
chriseth
reviewed
Nov 30, 2018
chriseth
reviewed
Nov 30, 2018
chriseth
reviewed
Nov 30, 2018
chriseth
reviewed
Nov 30, 2018
christianparpart
force-pushed
the
cp-SourceLocation-related-refactoring
branch
2 times, most recently
from
a1bd63e to
9908c8b
Compare
chriseth
reviewed
Nov 30, 2018
chriseth
reviewed
Nov 30, 2018
chriseth
reviewed
Nov 30, 2018
chriseth
reviewed
Nov 30, 2018
chriseth
reviewed
Nov 30, 2018
christianparpart
force-pushed
the
cp-SourceLocation-related-refactoring
branch
from
ef61405 to
b91639e
Compare
added 3 commits
November 30, 2018 17:07
…Stream source, eliminating sourceName Also, adapted affecting code to those changes.
…arStream already) Also, ParserBase::sourceName() was dead code. Eliminating it should increase test coverage (how sneaky) :-)
Especially also remove SourceLocation ctor's that the compiler can default-implement.
christianparpart
force-pushed
the
cp-SourceLocation-related-refactoring
branch
from
b91639e to
18e3d6d
Compare
christianparpart
changed the title
chriseth
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is the earliest in the series of PRs that needs to be merged "in order" :-).
Motivation: I noticed, that we pass (CharStream, filename) almost always as pair to Scanner, and then use complex ways (via callback functions) to get back to some functions that can extract the source code fragments (duplicated API from CharStream into Scanner) inside the SourceReferenceFormatter.
Gains:
Prerequisite of: #5535 (is based on top of this PR)