liblangutil: refactor SourceReferenceFormatter (split out extraction / line-cutting part). #5535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianparpart
force-pushed
the
cp-SourceReferenceExtractor
branch
from
b0f9440 to
75f2802
Compare
|
Why did you not modify SourceReferenceFormatter? I thought it was a refactor. Also there seem to be still some TODOs in the code. |
|
@chriseth, it is, but that's a splitout of the bigger PR. the code changes of the SourceReferenceFormatter are in the main PR. you asked me to split a few commits out. |
christianparpart
force-pushed
the
cp-SourceReferenceExtractor
branch
from
75f2802 to
e7bdf46
Compare
This comment has been minimized.
This comment has been minimized.
christianparpart
force-pushed
the
cp-SourceReferenceExtractor
branch
from
e7bdf46 to
b25b57c
Compare
christianparpart
changed the title
christianparpart
force-pushed
the
cp-SourceReferenceExtractor
branch
from
b25b57c to
cfa70ca
Compare
added 5 commits
November 29, 2018 12:28
…ame (and adapt codebase to it)
…Stream source, eliminating sourceName Also, adapted affecting code to those changes.
…arStream already) Also, ParserBase::sourceName() was dead code. Eliminating it should increase test coverage (how sneaky) :-)
…nderlying CharStream (which knows about the source's filename)
christianparpart
force-pushed
the
cp-SourceReferenceExtractor
branch
from
cfa70ca to
6aa9e67
Compare
|
due to rebase-fuckups with #5537, I cannot push onto the remote branch anymore. Have to start over, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds SourceReferenceExtractor API to liblangutil.
This is a prerequisite of #5511 - and can be merged early.
FYI: that API could receive get some tests. maybe in the PR or another?.