[2/3] Refactor SourceReferenceFormatter (split-out data extraction & make use of new SourceLocation knowledge) #5554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianparpart
force-pushed
the
cp-SourceReferenceFormatter-refactor
branch
from
4e087dd to
a3ea2aa
Compare
christianparpart
force-pushed
the
cp-SourceReferenceFormatter-refactor
branch
from
a3ea2aa to
93078a4
Compare
This comment has been minimized.
This comment has been minimized.
christianparpart
force-pushed
the
cp-SourceReferenceFormatter-refactor
branch
from
93078a4 to
4b1b9e9
Compare
christianparpart
changed the title
christianparpart
force-pushed
the
cp-SourceReferenceFormatter-refactor
branch
from
4b1b9e9 to
fcb6dc3
Compare
chriseth
reviewed
Dec 3, 2018
chriseth
reviewed
Dec 3, 2018
chriseth
reviewed
Dec 3, 2018
chriseth
reviewed
Dec 3, 2018
chriseth
reviewed
Dec 3, 2018
chriseth
reviewed
Dec 3, 2018
chriseth
reviewed
Dec 3, 2018
christianparpart
force-pushed
the
cp-SourceReferenceFormatter-refactor
branch
from
fcb6dc3 to
2cca0be
Compare
chriseth
reviewed
Dec 6, 2018
chriseth
reviewed
Dec 6, 2018
| m_stream << info.first << endl; | ||
| printSourceLocation(&info.second); | ||
| } | ||
| m_stream << endl; |
There was a problem hiding this comment.
I still don't understand the change in adding endl here, but it seems to be correct.
chriseth
reviewed
Dec 6, 2018
chriseth
reviewed
Dec 6, 2018
chriseth
suggested changes
Dec 6, 2018
…al and making use of new SourceLocation's CharStream knowledge
chriseth
force-pushed
the
cp-SourceReferenceFormatter-refactor
branch
from
2cca0be to
073b03d
Compare
chriseth
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is rebased on top of #5537.
That means: only the very last commit belongs to this PR (all prior belong to #5537).