-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add docs for CostTrigger
#600
Conversation
…st-aware-trackers
should I also review this already? |
…st-aware-trackers
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
=======================================
Coverage 85.82% 85.82%
=======================================
Files 257 257
Lines 11168 11168
=======================================
Hits 9585 9585
Misses 1583 1583 ☔ View full report in Codecov by Sentry. |
@MaxiBoether Should be ready, but it isn't time-critical. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Mostly looks good, I had few short comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…nto robin/feat/cost-aware-docs
Motivation
Lays out the architecture and core functionality of our new cost triggers
Also updating all other triggering docs along the way alongside some renamings to establish consistent naming