Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add docs for CostTrigger #600

Merged
merged 33 commits into from
Aug 30, 2024
Merged

docs: Add docs for CostTrigger #600

merged 33 commits into from
Aug 30, 2024

Conversation

robinholzi
Copy link
Collaborator

@robinholzi robinholzi commented Aug 20, 2024

Motivation

Lays out the architecture and core functionality of our new cost triggers

Also updating all other triggering docs along the way alongside some renamings to establish consistent naming

@robinholzi robinholzi changed the base branch from main to robin/feat/cost-aware-trackers August 20, 2024 14:56
@robinholzi robinholzi self-assigned this Aug 20, 2024
Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@MaxiBoether
Copy link
Contributor

should I also review this already?

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.82%. Comparing base (cbd1006) to head (0e04f5e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...l/triggers/dataincorporationlatency_costtrigger.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #600   +/-   ##
=======================================
  Coverage   85.82%   85.82%           
=======================================
  Files         257      257           
  Lines       11168    11168           
=======================================
  Hits         9585     9585           
  Misses       1583     1583           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinholzi robinholzi changed the base branch from robin/feat/cost-aware-trackers to main August 28, 2024 13:40
@robinholzi robinholzi changed the base branch from main to robin/feat/cost-trigger-avoidable-misclassifications August 28, 2024 18:05
@robinholzi
Copy link
Collaborator Author

@MaxiBoether Should be ready, but it isn't time-critical.

@robinholzi robinholzi marked this pull request as ready for review August 28, 2024 18:13
@robinholzi robinholzi requested a review from MaxiBoether August 28, 2024 18:13
Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Mostly looks good, I had few short comments

docs/pipeline/triggers/OVERVIEW.md Outdated Show resolved Hide resolved
docs/pipeline/triggers/COST_TRIGGER.md Outdated Show resolved Hide resolved
docs/pipeline/triggers/COST_TRIGGER.md Show resolved Hide resolved
@robinholzi robinholzi requested a review from MaxiBoether August 29, 2024 13:47
Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robinholzi robinholzi changed the base branch from robin/feat/cost-trigger-avoidable-misclassifications to main August 30, 2024 09:18
@robinholzi robinholzi merged commit 2251fd7 into main Aug 30, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants