-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add DynamicRollingAverageThresholdPolicy
#593
feat: Add DynamicRollingAverageThresholdPolicy
#593
Conversation
@MaxiBoether This should also be fairly straightforward, just another variation of dynamic thresholds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I could not immediately understand why the min(max) stuff can occur
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
=======================================
Coverage 85.11% 85.12%
=======================================
Files 244 244
Lines 10748 10768 +20
=======================================
+ Hits 9148 9166 +18
- Misses 1600 1602 +2 ☔ View full report in Codecov by Sentry. |
Motivation
Alongside the percentile-based dynamic threshold calibration, we also want to try out and offer a rolling average approach that checks for the deviation between the current distance and the rolling average and see if it exceeds a certain (relative/absolute) threshold.