Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add DynamicRollingAverageThresholdPolicy #593

Merged

Conversation

robinholzi
Copy link
Collaborator

Motivation

Alongside the percentile-based dynamic threshold calibration, we also want to try out and offer a rolling average approach that checks for the deviation between the current distance and the rolling average and see if it exceeds a certain (relative/absolute) threshold.

@robinholzi robinholzi self-assigned this Aug 18, 2024
Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@robinholzi robinholzi marked this pull request as ready for review August 19, 2024 12:13
@robinholzi robinholzi requested a review from MaxiBoether August 19, 2024 12:13
@robinholzi
Copy link
Collaborator Author

@MaxiBoether This should also be fairly straightforward, just another variation of dynamic thresholds

Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I could not immediately understand why the min(max) stuff can occur

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.12%. Comparing base (91c5fa3) to head (23a4060).
Report is 1 commits behind head on main.

Files Patch % Lines
...n/supervisor/internal/triggers/datadrifttrigger.py 66.66% 2 Missing ⚠️
...ervisor/internal/triggers/drift/decision_policy.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #593   +/-   ##
=======================================
  Coverage   85.11%   85.12%           
=======================================
  Files         244      244           
  Lines       10748    10768   +20     
=======================================
+ Hits         9148     9166   +18     
- Misses       1600     1602    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinholzi robinholzi merged commit 7968e72 into main Aug 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants