add save-defconfig cmd #1094
Merged
add save-defconfig cmd #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
radurentea
reviewed
Dec 14, 2023
There was a problem hiding this comment.
- Naming consistency question: I remember I used SDKConfig in the past, checking esp-idf documentation I see there is no naming consistency, should we stick with SDKCONFIG?
- The output from idf.py is not very straight forward as can be seen in this screenshot
- I think we should add a message to the output channel and focus it, in case notifications are off
- we can maybe also open/focus (if it's already opened) the sdkconfig.defaults file after the task is finished?
|
Pull request has been marked as |
radurentea
added
ongoing
brianignacio5
force-pushed
the
feature/save-defconfig
branch
from
30e5069 to
f68fe2f
Compare
brianignacio5
force-pushed
the
feature/save-defconfig
branch
from
f68fe2f to
b350dc8
Compare
|
@brianignacio5 hi ! Tested under:
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
ESP-IDF: Save Default SDKCONFIG file (save-defconfig)command to create asdkconfig.defaultsfile from current project usingidf.py save-defconfigcommand in the back.PTAL @boris-gu
Fixes #1090
Type of change
Please delete options that are not relevant.
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
IDF Save Default SDKCONFIGtask should show theidf.py save-defconfigoutput. Thesdkconfig.defaultsshould be generated.How has this been tested?
Manual testing of running command with blink example from ESP-IDF v5.0.4
Test Configuration:
Dependent components impacted by this PR:
Checklist