add idf version validation

espressif · Jan 19, 2024 · f68fe2f · f68fe2f
1 parent 3d2bb4c
commit f68fe2f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -140,6 +140,7 @@ Click <kbd>F1</kbd> to show Visual studio code actions, then type **ESP-IDF** to
 | Open NVS Partition Editor                               |                                        |                                           |
 | Pick a workspace folder                                 |                                        |                                           |
 | Remove Editor coverage                                  |                                        |                                           |
+| Save Default SDKCONFIG file (save-defconfig)            |                                        |                                           |
 | SDK Configuration editor                                | <kbd>⌘</kbd> <kbd>I</kbd> <kbd>G</kbd> | <kbd>Ctrl</kbd> <kbd>E</kbd> <kbd>G</kbd> |
 | Search in documentation...                              | <kbd>⌘</kbd> <kbd>I</kbd> <kbd>Q</kbd> | <kbd>Ctrl</kbd> <kbd>E</kbd> <kbd>Q</kbd> |
 | Select Flash Method                                     |                                        |                                           |

diff --git a/src/espIdf/menuconfig/saveDefConfig.ts b/src/espIdf/menuconfig/saveDefConfig.ts
@@ -68,7 +68,7 @@ export async function saveDefSdkconfig(
   TaskManager.addTask(
     {
       type: "esp-idf",
-      command: "IDF Save Default SDKCONFIG",
+      command: "ESP-IDF: Save Default SDKCONFIG",
       taskId: "idf-defconfig-task",
     },
     curWorkspaceFolder || TaskScope.Workspace,

diff --git a/src/extension.ts b/src/extension.ts
@@ -1787,7 +1787,8 @@ export async function activate(context: vscode.ExtensionContext) {
   });
 
   registerIDFCommand("espIdf.saveDefSdkconfig", async () => {
-    PreCheck.perform([openFolderCheck], () => {
+    const idfVersionCheck = await minIdfVersionCheck("5.0", workspaceRoot);
+    PreCheck.perform([idfVersionCheck, openFolderCheck], () => {
       vscode.window.withProgress(
         {
           cancellable: true,