Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add save-defconfig cmd #1094

Merged
merged 3 commits into from
Jan 25, 2024
Merged

add save-defconfig cmd #1094

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a757e8
add save-defconfig cmd
brianignacio5 Dec 13, 2023
d37112f
add idf version validation
brianignacio5 Dec 13, 2023
b350dc8
update notifications mode
brianignacio5 Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add idf version validation
  • Loading branch information
@brianignacio5
brianignacio5 committed Jan 23, 2024
commit d37112f50995109b113b9d6d545e087f4d27c561
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ Click <kbd>F1</kbd> to show Visual studio code actions, then type **ESP-IDF** to
| Open NVS Partition Editor | | |
| Pick a workspace folder | | |
| Remove Editor coverage | | |
| Save Default SDKCONFIG file (save-defconfig) | | |
| SDK Configuration editor | <kbd>⌘</kbd> <kbd>I</kbd> <kbd>G</kbd> | <kbd>Ctrl</kbd> <kbd>E</kbd> <kbd>G</kbd> |
| Search in documentation... | <kbd>⌘</kbd> <kbd>I</kbd> <kbd>Q</kbd> | <kbd>Ctrl</kbd> <kbd>E</kbd> <kbd>Q</kbd> |
| Select Flash Method | | |
Expand Down
2 changes: 1 addition & 1 deletion src/espIdf/menuconfig/saveDefConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export async function saveDefSdkconfig(
TaskManager.addTask(
{
type: "esp-idf",
command: "IDF Save Default SDKCONFIG",
command: "ESP-IDF: Save Default SDKCONFIG",
taskId: "idf-defconfig-task",
},
curWorkspaceFolder || TaskScope.Workspace,
Expand Down
3 changes: 2 additions & 1 deletion src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1787,7 +1787,8 @@ export async function activate(context: vscode.ExtensionContext) {
});

registerIDFCommand("espIdf.saveDefSdkconfig", async () => {
PreCheck.perform([openFolderCheck], () => {
const idfVersionCheck = await minIdfVersionCheck("5.0", workspaceRoot);
PreCheck.perform([idfVersionCheck, openFolderCheck], () => {
vscode.window.withProgress(
{
cancellable: true,
Expand Down