migrate Nighthawk Docker image from Alpine to Ubuntu#1315
Merged
fei-deng merged 1 commit intoenvoyproxy:mainfrom Mar 13, 2025
Merged
migrate Nighthawk Docker image from Alpine to Ubuntu#1315fei-deng merged 1 commit intoenvoyproxy:mainfrom
fei-deng merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
fei-deng
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We had to add
-lrt -latomicwhen #1309 updated to the latest Envoy.#1312 found that the Docker image no longer works because
libatomic.so.1is not found.Solution
The minimal solution to add
apk install libatomicwas not sufficient to fix the issue because of unknown Alpine issues.Migrating from Alpine to Ubuntu 22.04 and including
RUN apt-get update && apt-get install libatomic1appears to work. (Ubuntu SHA is copied from Envoy: https://github.com/envoyproxy/envoy/blob/f2023ef77bdb4abaf9feef963c9a0c291f55568f/ci/Dockerfile-envoy)Just changing the
FROMto Ubuntu 22.04, before addingapt-get install libatomic1, we start off with a similar error:After adding
apt-get install libatomic1, thenighthawk_clientexecutable can start:It is a low risk to publish a new Docker image based on the minimal confirmation above. The image can't be worse than the current image on Docker Hub that doesn't work.