Skip to content

Comments

migrate Nighthawk Docker image from Alpine to Ubuntu#1315

Merged
fei-deng merged 1 commit intoenvoyproxy:mainfrom
eric846:docker2
Mar 13, 2025
Merged

migrate Nighthawk Docker image from Alpine to Ubuntu#1315
fei-deng merged 1 commit intoenvoyproxy:mainfrom
eric846:docker2

Conversation

@eric846
Copy link
Contributor

@eric846 eric846 commented Mar 13, 2025

Problem

We had to add -lrt -latomic when #1309 updated to the latest Envoy.

#1312 found that the Docker image no longer works because libatomic.so.1 is not found.

Solution

The minimal solution to add apk install libatomic was not sufficient to fix the issue because of unknown Alpine issues.

Migrating from Alpine to Ubuntu 22.04 and including RUN apt-get update && apt-get install libatomic1 appears to work. (Ubuntu SHA is copied from Envoy: https://github.com/envoyproxy/envoy/blob/f2023ef77bdb4abaf9feef963c9a0c291f55568f/ci/Dockerfile-envoy)

Just changing the FROM to Ubuntu 22.04, before adding apt-get install libatomic1, we start off with a similar error:

ci/do_ci.sh docker
docker run envoyproxy/nighthawk-dev:latest nighthawk_client
nighthawk_client: error while loading shared libraries: libatomic.so.1: cannot open shared object file: No such file or directory

After adding apt-get install libatomic1, the nighthawk_client executable can start:

ci/do_ci.sh docker
docker run envoyproxy/nighthawk-dev:latest nighthawk_client
Bad argument: A URI or --multi-target-* options must be specified.

It is a low risk to publish a new Docker image based on the minimal confirmation above. The image can't be worse than the current image on Docker Hub that doesn't work.

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846 eric846 changed the title migrate Docker from Alpine to Ubuntu migrate Nighthawk Docker image from Alpine to Ubuntu Mar 13, 2025
@eric846 eric846 marked this pull request as ready for review March 13, 2025 15:22
@eric846 eric846 requested a review from fei-deng March 13, 2025 15:23
@fei-deng fei-deng merged commit 4d8654e into envoyproxy:main Mar 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants