Update Envoy to 78a8841 (Mar 07, 2025)#1309
Merged
fei-deng merged 5 commits intoenvoyproxy:mainfrom Mar 10, 2025
Merged
Conversation
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
fei-deng
approved these changes
Mar 10, 2025
This was referenced Mar 12, 2025
This was referenced Mar 13, 2025
fei-deng
pushed a commit
that referenced
this pull request
Mar 13, 2025
### Problem We had to add `-lrt -latomic` when #1309 updated to the latest Envoy. #1312 found that the Docker image no longer works because `libatomic.so.1` is not found. ### Solution The minimal solution to add `apk install libatomic` was not sufficient to fix the issue because of unknown Alpine issues. Migrating from Alpine to Ubuntu 22.04 and including `RUN apt-get update && apt-get install libatomic1` appears to work. (Ubuntu SHA is copied from Envoy: https://github.com/envoyproxy/envoy/blob/f2023ef77bdb4abaf9feef963c9a0c291f55568f/ci/Dockerfile-envoy) Just changing the `FROM` to Ubuntu 22.04, before adding `apt-get install libatomic1`, we start off with a similar error: ``` ci/do_ci.sh docker docker run envoyproxy/nighthawk-dev:latest nighthawk_client nighthawk_client: error while loading shared libraries: libatomic.so.1: cannot open shared object file: No such file or directory ``` After adding `apt-get install libatomic1`, the `nighthawk_client` executable can start: ``` ci/do_ci.sh docker docker run envoyproxy/nighthawk-dev:latest nighthawk_client Bad argument: A URI or --multi-target-* options must be specified. ``` It is a low risk to publish a new Docker image based on the minimal confirmation above. The image can't be worse than the current image on Docker Hub that doesn't work. Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
-latomicand-lrtto fix the CI build after envoyproxy/envoy#38430.