Fix Docker container after adding -latomic#1314
Closed
eric846 wants to merge 4 commits intoenvoyproxy:mainfrom
Closed
Fix Docker container after adding -latomic#1314eric846 wants to merge 4 commits intoenvoyproxy:mainfrom
eric846 wants to merge 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Member
|
@eric846 can you add a check for the CI? |
Contributor
Author
Contributor
Author
|
Now that we have a known-good Ubuntu workaround in #1312, I can try to migrate the container to Ubuntu, which is simpler. |
Contributor
Author
|
Closing in favor of #1315. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1309 we added
-latomic -lrt, but this caused #1312. The binaries in the Docker image can no longer start, failing to findlibatomic.so.1.apk add libatomicin the Docker container does not work because of unknown Alpine Linux issues.Instead we now build separate static versions of the Nighthawk binaries, solely for the Nighthawk in Docker.
Statically linking may lead to problems: https://groups.google.com/g/envoy-users/c/XK9M-RhWrxg/m/bgvUqtG2BwAJ.
Confirmed that the static Nighthawk binaries solve the
libatomic.so.1error and apparently fully start:It is worth a try publishing this version, since it can't get worse than the status quo where the Nighthawk Docker image doesn't work.
If the statically linked version fails, another possibility is to switch to Ubuntu as in https://github.com/envoyproxy/envoy/blob/main/ci/Dockerfile-envoy.