remove RateLimitFilter in favor of BackendTrafficPolicy (#2083)

* remove RateLimitFilter in favor of BackendTrafficPolicy

Relates to #2006

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix tests

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix e2e

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix docs

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* lint

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

api/v1alpha1/backendtrafficpolicy_types.go

@@ -49,7 +49,7 @@ type BackendTrafficPolicySpec struct {
 	// RateLimit allows the user to limit the number of incoming requests
 	// to a predefined value based on attributes within the traffic flow.
 	// +optional
-	RateLimit *RateLimitFilterSpec `json:"rateLimit,omitempty"`
+	RateLimit *RateLimitSpec `json:"rateLimit,omitempty"`
 
 	// LoadBalancer policy to apply when routing traffic from the gateway to
 	// the backend endpoints

api/v1alpha1/ratelimitfilter_types.go → api/v1alpha1/ratelimit_types.go

@@ -5,31 +5,9 @@
 
 package v1alpha1
 
-import (
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-)
-
-const (
-	// KindRateLimitFilter is the name of the RateLimitFilter kind.
-	KindRateLimitFilter = "RateLimitFilter"
-)
-
-// +kubebuilder:object:root=true
-// +kubebuilder:printcolumn:name="Age",type=date,JSONPath=`.metadata.creationTimestamp`
-
-// RateLimitFilter allows the user to limit the number of incoming requests
-// to a predefined value based on attributes within the traffic flow.
-type RateLimitFilter struct {
-	metav1.TypeMeta   `json:",inline"`
-	metav1.ObjectMeta `json:"metadata,omitempty"`
-
-	// Spec defines the desired state of RateLimitFilter.
-	Spec RateLimitFilterSpec `json:"spec"`
-}
-
-// RateLimitFilterSpec defines the desired state of RateLimitFilter.
+// RateLimitSpec defines the desired state of RateLimitSpec.
 // +union
-type RateLimitFilterSpec struct {
+type RateLimitSpec struct {
 	// Type decides the scope for the RateLimits.
 	// Valid RateLimitType values are "Global".
 	//
@@ -184,16 +162,3 @@ type RateLimitValue struct {
 //
 // +kubebuilder:validation:Enum=Second;Minute;Hour;Day
 type RateLimitUnit string
-
-//+kubebuilder:object:root=true
-
-// RateLimitFilterList contains a list of RateLimitFilter resources.
-type RateLimitFilterList struct {
-	metav1.TypeMeta `json:",inline"`
-	metav1.ListMeta `json:"metadata,omitempty"`
-	Items           []RateLimitFilter `json:"items"`
-}
-
-func init() {
-	SchemeBuilder.Register(&RateLimitFilter{}, &RateLimitFilterList{})
-}