Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RateLimitFilter & AuthenticaionFilter #2006

Closed
arkodg opened this issue Oct 19, 2023 · 2 comments
Closed

Remove RateLimitFilter & AuthenticaionFilter #2006

arkodg opened this issue Oct 19, 2023 · 2 comments
Assignees
@arkodg
Labels
release-note Indicates a required release note
Milestone
0.6.0-rc1

Comments

@arkodg
Copy link
Contributor

arkodg commented Oct 19, 2023 •
edited
Loading

Description:

Remove these filters and add these features as fields in BackendTrafficPolicy & SecurityPolicy

This will be a breaking change that needs to be highlighted in the release notes
@arkodg arkodg added the release-note Indicates a required release note label Oct 19, 2023
@arkodg arkodg added this to the 0.6.0-rc1 milestone Oct 19, 2023
@arkodg arkodg self-assigned this Oct 19, 2023
@zirain
Copy link
Contributor

zirain commented Oct 19, 2023

will BackendTrafficPolicy & SecurityPolicy ready in v0.6?

@arkodg
Copy link
Contributor Author

arkodg commented Oct 19, 2023

thats the plan @zirain, we are trying :)

arkodg added a commit to arkodg/gateway that referenced this issue Oct 24, 2023
@arkodg
Add rateLimit to BackendTrafficPolicy
bdbeb07 
Relates to envoyproxy#1821 & envoyproxy#2006

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg mentioned this issue Oct 24, 2023
Merged
arkodg added a commit to arkodg/gateway that referenced this issue Oct 25, 2023
@arkodg
Add rateLimit to BackendTrafficPolicy
a5f49af 
Relates to envoyproxy#1821 & envoyproxy#2006

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg added a commit that referenced this issue Oct 25, 2023
@arkodg
Add rateLimit to BackendTrafficPolicy (#2060)
e4d9d7e 
* Add rateLimit to BackendTrafficPolicy

Relates to #1821 & #2006

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* tests

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* lint

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix build

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg mentioned this issue Oct 26, 2023
Closed
arkodg added a commit to arkodg/gateway that referenced this issue Oct 26, 2023
@arkodg
remove RateLimitFilter in favor of BackendTrafficPolicy
5190dbd 
Relates to envoyproxy#2006

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg mentioned this issue Oct 26, 2023
Merged
arkodg added a commit that referenced this issue Oct 27, 2023
@arkodg
remove RateLimitFilter in favor of BackendTrafficPolicy (#2083)
54803c1 
* remove RateLimitFilter in favor of BackendTrafficPolicy

Relates to #2006

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix tests

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix e2e

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix docs

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* lint

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg closed this as completed Oct 27, 2023
@s0uky s0uky mentioned this issue Oct 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkodg arkodg

Labels
release-note Indicates a required release note
Projects
None yet
Milestone
0.6.0-rc1
Development

No branches or pull requests
2 participants
@zirain @arkodg