Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove RateLimitFilter in favor of BackendTrafficPolicy #2083

Merged
merged 5 commits into from
Oct 27, 2023
Merged

remove RateLimitFilter in favor of BackendTrafficPolicy #2083

merged 5 commits into from
Oct 27, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Oct 26, 2023

Relates to #2006

@arkodg
remove RateLimitFilter in favor of BackendTrafficPolicy
5190dbd 
Relates to envoyproxy#2006

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner October 26, 2023 17:57
@arkodg arkodg marked this pull request as draft October 26, 2023 17:57
@arkodg
fix tests
36867b3 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg added the release-note Indicates a required release note label Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #2083 (c607f0e) into main (6b8794e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2083      +/-   ##
==========================================
+ Coverage   64.32%   64.33%   +0.01%     
==========================================
  Files         107      107              
  Lines       14944    14694     -250     
==========================================
- Hits         9613     9454     -159     
+ Misses       4739     4663      -76     
+ Partials      592      577      -15
Files Coverage Δ
internal/cmd/egctl/translate.go 82.78% <ø> (-0.34%) ⬇️
internal/gatewayapi/filters.go 81.19% <ø> (+1.28%) ⬆️
internal/gatewayapi/helpers.go 87.04% <ø> (+3.13%) ⬆️
internal/gatewayapi/resource.go 66.07% <ø> (+1.15%) ⬆️
internal/gatewayapi/route.go 88.31% <ø> (-0.05%) ⬇️
internal/gatewayapi/zz_generated.deepcopy.go 0.00% <ø> (ø)
internal/provider/kubernetes/controller.go 52.64% <ø> (-0.40%) ⬇️
internal/provider/kubernetes/filters.go 46.66% <ø> (-5.65%) ⬇️
internal/provider/kubernetes/predicates.go 53.57% <ø> (+0.03%) ⬆️
internal/provider/kubernetes/routes.go 55.17% <100.00%> (-0.83%) ⬇️

@arkodg
fix e2e
840e4e8 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg marked this pull request as ready for review October 26, 2023 19:23
@arkodg arkodg requested review from a team, kflynn, zhaohuabing and shawnh2 and removed request for a team October 26, 2023 19:23
@arkodg
fix docs
24700b9 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg
lint
c607f0e 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
zirain
zirain approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

zhaohuabing
zhaohuabing approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkodg arkodg merged commit 54803c1 into envoyproxy:main Oct 27, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

@zirain zirain zirain approved these changes

@kflynn kflynn Awaiting requested review from kflynn kflynn was automatically assigned from envoyproxy/gateway-reviewers

@shawnh2 shawnh2 Awaiting requested review from shawnh2 shawnh2 was automatically assigned from envoyproxy/gateway-reviewers

Assignees
No one assigned
Labels
release-note Indicates a required release note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkodg @zhaohuabing @zirain