Skip to content

Rebaseline code size test expectations. NFC. #13940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2021
Merged

Rebaseline code size test expectations. NFC. #13940

merged 1 commit into from
Apr 20, 2021

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Apr 20, 2021 •
edited
Loading

Generated by running:

EMTEST_REBASELINE=1 ./tests/runner other.test_minimal_runtime_code_size*

@kripken
Copy link
Member

kripken commented Apr 20, 2021

#13936 just did this a few moments ago - I'm surprised there are any changes?

@sbc100
Copy link
Collaborator Author

sbc100 commented Apr 20, 2021

Hmm.. I think maybe my llvm was at tot which has not rolled in yet.. checking

@sbc100
Copy link
Collaborator Author

sbc100 commented Apr 20, 2021

These changes are valid according to llvm at dc35593e3f2bfd04d85cf151c97e0738ce66887e which is currently tot in emscripten-releases.

if you like you can confirm locally?

@sbc100
Copy link
Collaborator Author

sbc100 commented Apr 20, 2021

I decided to split out the metadce change in tests_core.py: #13942

@sbc100 sbc100 enabled auto-merge (squash) April 20, 2021 20:40
@sbc100 sbc100 merged commit 05b914b into main Apr 20, 2021
@sbc100 sbc100 deleted the rebaseline branch April 20, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @kripken