Skip to content

Accept minor code size regressions after LLVM update #13936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Accept minor code size regressions after LLVM update #13936

merged 1 commit into from
Apr 20, 2021

Conversation

kripken
Copy link
Member

@kripken kripken commented Apr 20, 2021

LLVM change: llvm/llvm-project@9423f78

That uses unsigned operations in more places. Those are less size-efficient
than signed ones in wasm2js, so unfortunately this increases code size there.
I do not see a simple way to optimize things better in wasm2js - the LLVM
change just switches to an unsigned operation, but then that gets taken
into account in later work - apparently sometimes helpful, hence the change -
and the result is not a simple unsigned operation we can replace easily.

@kripken kripken requested review from sbc100 and aardappel April 20, 2021 18:06
@kripken kripken merged commit 5403790 into main Apr 20, 2021
@kripken kripken deleted the accept branch April 20, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants