Accept minor code size regressions after LLVM update #13936
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM change: llvm/llvm-project@9423f78
That uses unsigned operations in more places. Those are less size-efficient
than signed ones in wasm2js, so unfortunately this increases code size there.
I do not see a simple way to optimize things better in wasm2js - the LLVM
change just switches to an unsigned operation, but then that gets taken
into account in later work - apparently sometimes helpful, hence the change -
and the result is not a simple unsigned operation we can replace easily.