Update test_console_log. NFC. #13088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sbc100
commented
Dec 22, 2020
sbc100
commented
- Use btest_exit (avoid REPORT_RESULT)
- Fix formatting
- Return zero on success
- Use btest_exit (avoid REPORT_RESULT) - Fix formatting - Return zero on success
|
View diff with ignore whitespace. |
tlively
approved these changes
Dec 22, 2020
|
|
||
| DoubleTest(); | ||
|
|
||
| #ifdef REPORT_RESULT |
There was a problem hiding this comment.
Where was this defined? Is it still defined somewhere? Can we get rid of it?
There was a problem hiding this comment.
Sorry I should have given more context.
Traditionally when you run browser test self.btest the test running will inject the report_result.h header (using -include) and expect you to call REPORT_RESULT. However, in recent months I've added self.btest_exit which just relies on the exit code instead. It doesn't inject any headers and it doesn't use this macro. See #12928 and #12977.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.