Convert sample batch of browser tests to avoid REPORT_RESULT #12977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
avoid_report_result
branch
3 times, most recently
from
2f9167f to
8e8fbbe
Compare
sbc100
force-pushed
the
browser_test_warnings
branch
2 times, most recently
from
a3fa14c to
b646a78
Compare
sbc100
force-pushed
the
avoid_report_result
branch
2 times, most recently
from
6e419ec to
a6d05e2
Compare
sbc100
force-pushed
the
browser_test_warnings
branch
from
b646a78 to
921c5a3
Compare
sbc100
force-pushed
the
avoid_report_result
branch
3 times, most recently
from
dfb6f73 to
80b9d16
Compare
kripken
reviewed
Dec 9, 2020
sbc100
force-pushed
the
avoid_report_result
branch
from
80b9d16 to
49988b5
Compare
kripken
approved these changes
Dec 11, 2020
sbc100
force-pushed
the
avoid_report_result
branch
from
b3e0a61 to
d69c4a8
Compare
For simple browser tests we can just rely on the process exit code being reported. I've added a new btest_exit method so that tests can opt into this new behavior. This allows test code to be identical whether running in the browser or outside.
sbc100
force-pushed
the
avoid_report_result
branch
from
59a831b to
77cce4b
Compare
|
I ended up going for the enum approach as it made more sense to me in the end. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For simple browser tests we can just rely on the process
exit code being reported. I've added a new btest_exit
method so that tests can opt into this new behavior.
This allows test code to be identical whether running
in the browser or outside.