Automatically report exit status in browser tests #12928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
browsertest_exit_status
branch
from
bd6f298 to
c306f53
Compare
kripken
approved these changes
Dec 1, 2020
sbc100
force-pushed
the
browsertest_exit_status
branch
from
c306f53 to
62d3011
Compare
sbc100
added a commit
that referenced
this pull request
Dec 1, 2020
Because this header is force-included into all browser tests it should be as un-intrusive as possible. This also involved adding includes to a few tests that were indirectly relying on these includes. Better to IWYN. Split out from #12928
sbc100
added a commit
that referenced
this pull request
Dec 1, 2020
Because this header is force-included into all browser tests it should be as un-intrusive as possible. This also involved adding includes to a few tests that were indirectly relying on these includes. Better to IWYN. Split out from #12928
sbc100
force-pushed
the
browsertest_exit_status
branch
2 times, most recently
from
7534ead to
4dc0974
Compare
|
Requires #12933 |
This means that tests don't necessarily need to call REPORT_RESULT. I'm going to be taking advantage of this in #12923. Also, don't initialize EXIT_STATUS to zero, but leave it as undefined. It seems useful to be able to tell the diference between a program that exits with a zero status and one that has not in fact exited yet.
sbc100
force-pushed
the
browsertest_exit_status
branch
from
4dc0974 to
a6ddc6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that tests don't necessarily need to call REPORT_RESULT.
I'm going to be taking advantage of this in #12923.