(5/5) Multiple Issues: Introduce magnetic edge center #184
Conversation
This is a prep PR needed for the following PRs: - snap widgets after mouse button release - close gaps after mouse button release - fix intersects after mouse button release - align display_widget edges/center Changes in this PR - change the meaning of display_widget.delta: from distance of in widget units to distance in monitor/pixel units The expression ```vala delta_x = (int)(event.x_root - start_x); delta_y = (int)(event.y_root - start_y); ``` led to the loss of information and as the distance in widgets units is always less than the distance in monitor units. There no 1-to-1 mapping was possible. With the expression ```vala display_widget.delta_x = (int) (diff_x / current_ratio); display_widget.delta_y = (int) (diff_y / current_ratio); ``` a 1-to-1 mapping between the widget units and monitor units is possible as the integer cast happens after the float division! - rename move_display to end_grab as the signal is only emitted when the mouse button is released - introduce new signal called `move_display` which is emitted when widget is moved
- a more concise widget snapping algorithm - also fixes some issues when the widgets were perfectly aligned
- check intersections after mouse button release: this makes it possible to place a monitor between to others - also fix issue: for 3 and more monitors it was possible to create intersections between monitors
This is intentional as diagonal monitors are not allowed. Maybe I could increase the offset to make it more obvious that it is the intended behavior? I have also thought about a minimal offset of 1px. But this would make it difficult to move the cursor between displays. So I think it is reasonable to use minimal offset of 50px. |
…ors_after_mouse_button_release
…hub.com:andreasfelix/switchboard-plug-display into 2_of_5_snap_monitors_after_mouse_button_release
…_of_5_close_gaps_after_mouse_button_release
….com:andreasfelix/switchboard-plug-display into 3_of_5_close_gaps_after_mouse_button_release
…_5_fix_intersections_after_mouse_button_release
This reverts commit 2ef6b0e.
…to 5_of_5_introduce_magnetic_edge_center
This reverts commit f2fabf8.
…_5_fix_intersections_after_mouse_button_release
…hub.com:andreasfelix/switchboard-plug-display into 2_of_5_snap_monitors_after_mouse_button_release
….com:andreasfelix/switchboard-plug-display into 3_of_5_close_gaps_after_mouse_button_release
…_of_5_close_gaps_after_mouse_button_release
…_of_5_close_gaps_after_mouse_button_release
…_of_5_close_gaps_after_mouse_button_release
…_5_fix_intersections_after_mouse_button_release
…to 5_of_5_introduce_magnetic_edge_center
…to 5_of_5_introduce_magnetic_edge_center
|
I wanted to ask - as completely rewrote the widget-snapping, gap-detection, intersection-detection and widget-alignment algorithms - if it is okay if I would add myself to the |
There was a problem hiding this comment.
Works well. Still occasional 1 pixel gap between display rectangles but I think that can be cleaned up in another PR if it causes an issue.
Currently, you have the most blame for this file so I have no objection to you being one of the authors. Better get OK from original author @tintou though.
(5/5) Split up #177 in different PRs:
Needs to be merged after #183
Changes in this PR:
Can be disabled by pressing Ctrl