(4/5) Multiple Issues: Fix intersections after mouse button release #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a prep PR needed for the following PRs: - snap widgets after mouse button release - close gaps after mouse button release - fix intersects after mouse button release - align display_widget edges/center Changes in this PR - change the meaning of display_widget.delta: from distance of in widget units to distance in monitor/pixel units The expression ```vala delta_x = (int)(event.x_root - start_x); delta_y = (int)(event.y_root - start_y); ``` led to the loss of information and as the distance in widgets units is always less than the distance in monitor units. There no 1-to-1 mapping was possible. With the expression ```vala display_widget.delta_x = (int) (diff_x / current_ratio); display_widget.delta_y = (int) (diff_y / current_ratio); ``` a 1-to-1 mapping between the widget units and monitor units is possible as the integer cast happens after the float division! - rename move_display to end_grab as the signal is only emitted when the mouse button is released - introduce new signal called `move_display` which is emitted when widget is moved
- a more concise widget snapping algorithm - also fixes some issues when the widgets were perfectly aligned
- check intersections after mouse button release: this makes it possible to place a monitor between to others - also fix issue: for 3 and more monitors it was possible to create intersections between monitors
This was referenced Aug 27, 2019
jeremypw
requested changes
Sep 24, 2019
…ors_after_mouse_button_release
…hub.com:andreasfelix/switchboard-plug-display into 2_of_5_snap_monitors_after_mouse_button_release
…_of_5_close_gaps_after_mouse_button_release
….com:andreasfelix/switchboard-plug-display into 3_of_5_close_gaps_after_mouse_button_release
…_5_fix_intersections_after_mouse_button_release
This reverts commit 2ef6b0e.
…_5_fix_intersections_after_mouse_button_release
|
@andreasfelix It looks like only a pixel gap on-screen so is probably some kind of rounding error - I'll investigate further. |
…hub.com:andreasfelix/switchboard-plug-display into 2_of_5_snap_monitors_after_mouse_button_release
….com:andreasfelix/switchboard-plug-display into 3_of_5_close_gaps_after_mouse_button_release
…_of_5_close_gaps_after_mouse_button_release
…_of_5_close_gaps_after_mouse_button_release
…_of_5_close_gaps_after_mouse_button_release
…_5_fix_intersections_after_mouse_button_release
|
Does not compile after merging master |
jeremypw
requested changes
Oct 1, 2019
There was a problem hiding this comment.
Small gaps still sometimes appear between monitors (as displayed) but I think this may be fixed by part 5/5.
More of a problem is that if a monitor is dropped on top of another, the underlying monitor moves out of the way (even if it has previously been carefully aligned). In my opinion the mis-dropped monitor should be moved to an 'allowed' position instead without moving the remaining monitors.
|
As it looks like it is intended to drop a monitor between two others, my previous comment regarding moving the dropped monitor can be disregarded. |
jeremypw
approved these changes
Oct 6, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(4/5) Split up #177 in different PRs:
Needs to be merged after #182
Changes in this PR: