(1/5) Multiple issues: Prep #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a prep PR needed for the following PRs: - snap widgets after mouse button release - close gaps after mouse button release - fix intersects after mouse button release - align display_widget edges/center Changes in this PR - change the meaning of display_widget.delta: from distance of in widget units to distance in monitor/pixel units The expression ```vala delta_x = (int)(event.x_root - start_x); delta_y = (int)(event.y_root - start_y); ``` led to the loss of information and as the distance in widgets units is always less than the distance in monitor units. There no 1-to-1 mapping was possible. With the expression ```vala display_widget.delta_x = (int) (diff_x / current_ratio); display_widget.delta_y = (int) (diff_y / current_ratio); ``` a 1-to-1 mapping between the widget units and monitor units is possible as the integer cast happens after the float division! - rename move_display to end_grab as the signal is only emitted when the mouse button is released - introduce new signal called `move_display` which is emitted when widget is moved
jeremypw
requested changes
Sep 24, 2019
jeremypw
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1/5) Split up #177 into different PRs:
This is a prep PR needed for the following PRs:
Changes in this PR:
change the unit of
display_widget.deltafrom widget units to monitor/pixel unitsThe integer cast
should be done after dividing by
current_ratio. The distance in widgets units isalways less than the distance in monitor units. So doing the integer cast before dividing by
current_ratiomakes it not possible to arbitrary position the monitors as the rounding of doubleleads to information loss .
With the expression
a 1-to-1 mapping between the widget units and monitor units is possible
as the integer cast happens after the float division!
rename
move_displaytoend_grabas the signal is only emitted when the mouse button is releasedintroduce new signal called
move_displaywhich is emitted when widget is movedset
holdingalways to false if the mouse button is released, which solves (The display rectangle is "running away" from my pointer #34, Triple-monitor setup screens not lining up #35.4)