-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Poll] Error handling for push rules synchronization #8141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florian14
changed the base branch from
develop
to
feature/fre/poll_sync_push_rules_after_creation
February 17, 2023 09:33
Base automatically changed from
feature/fre/poll_sync_push_rules_after_creation
to
develop
February 17, 2023 12:46
Florian14
force-pushed
the
feature/fre/poll_sync_error_handling
branch
from
February 20, 2023 13:02
b124b02
to
29d4a17
Compare
Florian14
requested review from
a team and
yostyle
and removed request for
a team
February 20, 2023 14:21
Florian14
force-pushed
the
feature/fre/poll_sync_error_handling
branch
from
February 23, 2023 08:24
29d4a17
to
021babc
Compare
ElementBot
reviewed
Feb 23, 2023
} | ||
} | ||
} | ||
|
||
protected fun refreshDisplay() { | ||
listView?.adapter?.notifyDataSetChanged() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ It will always be more efficient to use more specific change events if you can. Rely onnotifyDataSetChanged
as a last resort.⚠️ It will always be more efficient to use more specific change events if you can. Rely onnotifyDataSetChanged
as a last resort.
SonarCloud Quality Gate failed. |
yostyle
reviewed
Feb 23, 2023
vector/src/main/java/im/vector/app/core/session/ConfigureAndStartSessionUseCase.kt
Outdated
Show resolved
Hide resolved
yostyle
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Display an error in the settings screen when push rules are out of sync (after opening the screen or modifying the rules)
Added a live refresh of the notification setting screens when the account data is updated (eg. from another client)
Motivation and context
Error handling of the new push rules introduced in #8114
Screenshots / GIFs
Tests
On a synapse supporting the new push rules
/devtools
from a web instance)Note that the rules should be automatically realigned by #8130 so the error may be not visible
Tested devices
Checklist