[Poll] Synchronize polls and message push rules after creation (PSG-1137) #8130
Conversation
Florian14
changed the title
Florian14
force-pushed
the
feature/fre/poll_sync_push_rules_after_creation
branch
from
014556d
to
61c3f55
Compare
Florian14
requested review from
a team,
jmartinesp and
jonnyandrew
and removed request for
a team and
jmartinesp
Florian14
force-pushed
the
feature/fre/poll_new_push_rules
branch
from
d55b281
to
0a0ad2d
Compare
Florian14
force-pushed
the
feature/fre/poll_sync_push_rules_after_creation
branch
from
61c3f55
to
529f640
Compare
| ) | ||
| else -> emptyList() | ||
| } | ||
| fun RuleIds.getParentRule(ruleId: String): String? { |
There was a problem hiding this comment.
Could be worth adding a comment here to explain what a parent rule is?
There was a problem hiding this comment.
Yeah, I'm also wondering if this should be moved outside of the sdk, this relation between the push rules is mentioned in the MSC but their connection is done at the application side (the clients are not forced to apply this relation, but on the other hand it could also be interesting to share this information at the sdk level... wdyt?)
There was a problem hiding this comment.
I couldn't find any mention of parent rules in the MSC3930. Is that the right place to look?
There was a problem hiding this comment.
The term "parent" is not mentioned, I was talking about these references to m.room.message rule:
In order to have polls behave similar to message events, the following underride push rules are defined. Note that the push rules are mirrored from those available to m.room.message events.
Typically these rules would be kept in sync with the m.room.message rules they are based upon, however there is no requirement to do so. A client's approach might be to only keep them in sync while setting the values, rather than monitoring for changes to push rules.
There was a problem hiding this comment.
It sounds like more of a recommendation from the MSC about how the push rules might be related. In a different app, for example one that is based around polls rather than messages, I guess the parent relation might be reversed?
So I'm leaning towards moving this out of the SDK.
There was a problem hiding this comment.
You're totally right, I moved the extensions to the vector module dcd43d6
|
Kudos, SonarCloud Quality Gate passed! |
Florian14
deleted the
feature/fre/poll_sync_push_rules_after_creation
branch
Type of change
Content
Add an observer on the push rule updates in the account data and realign the push rules with their parent if needed.
Motivation and context
#8114 introduces the new push rules in the notification settings. The new rules should be aligned with their parent rules as described in the following table:
The purpose of this PR is to verify and fix if necessary the consistency of the new rules with their parent when changes are detected in the account data.
Screenshots / GIFs
Tests
Tested devices
Checklist