-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Poll] Synchronize polls push rules with message push rules (PSG-954) #8114
Conversation
d55b281
to
0a0ad2d
Compare
|
SonarCloud Quality Gate failed. |
import kotlinx.coroutines.launch | ||
import org.matrix.android.sdk.api.session.pushrules.RuleIds | ||
import org.matrix.android.sdk.api.session.pushrules.rest.PushRuleAndKind | ||
|
||
// TODO This fragment seems not used anymore, we can probably delete it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth doing this now while we're already making changes to notification preference screens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it initially but it involved also removing the related resources. I preferred to revert to not include more changes in the PR and I was wondering if it could be used in f-droid (even if I did not find any usage). Wdyt @bmarty? If we can remove it, I'll handle it in a separate PR.
Type of change
Content
Add the new push rules for the polls related to the MSC3930.
Bind the new rules in the notification settings with the existing rules for direct messages and group messages.
Also:
deleted unused advanced notifications fragmentPreference
from the class names)Motivation and context
Close #8007
Note: the error handling and the initial sync of the rules when they are received from the server will be done in dedicated PRs.
Screenshots / GIFs
Tests
Needs a server supporting the new MSC for testing
Tested devices
Checklist