fix: don't activate when downloading versions from settings#1242
Merged
codebytere merged 3 commits intomainfrom Feb 1, 2023
Merged
fix: don't activate when downloading versions from settings#1242codebytere merged 3 commits intomainfrom
codebytere merged 3 commits intomainfrom
Conversation
dsanders11
reviewed
Jan 19, 2023
ckerr
approved these changes
Jan 19, 2023
Member
ckerr
left a comment
ckerr
left a comment
There was a problem hiding this comment.
I do have a nit to pick but the main idea in this PR LGTM
codebytere
force-pushed
the
fix-settings-download
branch
from
64c0d4c to
dce7f90
Compare
dsanders11
reviewed
Jan 31, 2023
codebytere
force-pushed
the
fix-settings-download
branch
from
a58a43b to
ae22bd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1238.
fiddle-corewas installing versions and activating them regardless of origin - when a version is downloaded from settings it should not be activated.