fix: don't activate when downloading versions from settings

src/renderer/components/settings-electron.tsx

@@ -383,7 +383,7 @@ export const ElectronSettings = observer(
           buttonProps.onClick = () => {
             isLocal
               ? appState.removeVersion(ver)
-              : appState.downloadVersion(ver);
+              : appState.downloadVersion(ver, { activate: false });
           };
           break;
       }

src/renderer/state.ts

@@ -577,12 +577,18 @@ export class AppState {
   }
 
   /**
-   * Download a version of Electron.
+   * Download a version of Electron and set it as the current
+   * version in use unless otherwise specified.
    *
    * @param {RunnableVersion} ver
+   * @param {Object} opts
+   * @param {Boolean} [options.activate=true] - Whether to set ver as current
    * @returns {Promise<void>}
    */
-  public async downloadVersion(ver: RunnableVersion) {
+  public async downloadVersion(
+    ver: RunnableVersion,
+    opts: { activate: boolean } = { activate: true },
+  ) {
     const { source, state, version } = ver;
     const {
       electronMirror,
@@ -611,7 +617,8 @@ export class AppState {
     }
 
     console.log(`State: Downloading Electron ${version}`);
-    await this.installer.install(version, {
+
+    const options = {
       mirror: {
         electronMirror,
         electronNightlyMirror,
@@ -625,7 +632,15 @@ export class AppState {
           }
         });
       },
-    });
+    };
+
+    // Download the version without setting it as the current version.
+    if (!opts.activate) {
+      await this.installer.ensureDownloaded(version, options);
+      return;
+    }
+
+    await this.installer.install(version, options);
   }
 
   /**

src/renderer/versions.ts

@@ -107,7 +107,7 @@ function getVersions(
  * Save an array of GitHubVersions to localStorage.
  *
  * @param {VersionKeys} key
- * @param {Array<Version} versions
+ * @param {Array<Version>} versions
  */
 function saveVersions(key: VersionKeys, versions: Array<Version>) {
   const stringified = JSON.stringify(versions);