Merged
Conversation
dsanders11
force-pushed
the
dont-eager-install
branch
from
3ccbb39 to
584af3a
Compare
2 tasks
codebytere
approved these changes
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1366.
Don't do the install step for a version until the user tries to run a fiddle. Doing so avoids collision on disk from multiple versions being installed at once (see reference issue). Also provides a nicer UX by not showing the unzipping spinner every time on start. Trade off is slightly longer initial run for a version since it needs to be unzipped and installed, but subsequent runs with the same version skip that step.
Should hopefully clear up a number of the disk errors being seen on Sentry around version management.
This partially reverts #1242 since that behavior becomes the only behavior.