Fix wrong import in data plugin causing 100kB bundle increase #93448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@elasticmachine merge upstream |
Dosant
added
v7.12.0
v7.13.0
v8.0.0
bug
Dosant
changed the title
Contributor
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
spalger
approved these changes
Mar 3, 2021
Contributor
spalger
left a comment
spalger
left a comment
There was a problem hiding this comment.
Operations: LGTM, though it looks like x-pack ciGroup11 never completed so this will need to run CI one more time
Contributor
|
@elasticmachine merge upstream |
mattkime
approved these changes
Mar 3, 2021
Contributor
mattkime
left a comment
mattkime
left a comment
There was a problem hiding this comment.
nice work! changes lgtm
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Module Count
Page load bundle
History
To update your PR or re-run it, just comment with: |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Mar 4, 2021
…c#93448) # Conflicts: # api_docs/data.json # api_docs/data_search.json
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Mar 4, 2021
…c#93448) # Conflicts: # api_docs/data.json # api_docs/data_search.json # src/plugins/data/common/search/search_source/search_source.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 4, 2021
* master: (48 commits) Fix wrong import in data plugin causing 100kB bundle increase (elastic#93448) [Fleet] Correctly track install status of an integration (elastic#93464) Reviews data frame analytics UI text (elastic#93033) Display multiple copyable fields for process.args in resolver node detail panel (elastic#93280) [Security Solution][Detections] ML Popover overflow fix (elastic#93525) chore(NA): do not use execa on bazel workspace status update script (elastic#93532) Bump dependencies (elastic#93511) [dev/build_ts_refs] support disabling the ts-refs build completely (elastic#93529) [Security Solution] fix data provider cypress test (elastic#93465) Fix service map for All environment single service (elastic#93517) [Fleet] Fix package version comparaison in the UI (elastic#93498) [alerting] adds doc on JSON-expanded action variables and task manager max_workers (elastic#92720) [dev/build_ts_refs] ignore type checking failures when building ts refs (elastic#93473) [core-new-docs] Adds a dev-doc for core documentation (elastic#92976) remove opacity from maps legacy style (elastic#93456) [Security Solution][Lists] Escape quotes in list ids and quote the id in KQL query (elastic#93176) Revert "Make tests deterministic by providing unique timestamps (elastic#93350)" [Discover] Fix link from dashboard saved search to Discover (elastic#92937) update public api docs App Search - Polishing Analytics Views (elastic#92939) ...
Dosant
added a commit
that referenced
this pull request
Mar 4, 2021
#93577) # Conflicts: # api_docs/data.json # api_docs/data_search.json
Dosant
added a commit
that referenced
this pull request
Mar 4, 2021
#93580) # Conflicts: # api_docs/data.json # api_docs/data_search.json # src/plugins/data/common/search/search_source/search_source.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently there was a spike in the bundle size of a data plugin:
Bundle increase is due to a wrong import here: https://github.com/elastic/kibana/pull/89837/files#diff-f5d77ff6e6565947682c3df9063d53fe04bc19e5b3ee4ed292e9a33494308702R65
This pr fixes the import, hardens data plugin bundle limits, and adds that import into restricted imports.